feat: list consent sessions by session id #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Nov 13, 2021
aarmam
changed the title
|
Let me know if ready for 👀 by clicking "ready for review"! |
aarmam
force-pushed
the
feature/list-consent-sessions
branch
from
b70391d to
26a6230
Compare
Codecov Report
@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
+ Coverage 76.82% 76.95% +0.13%
==========================================
Files 123 123
Lines 8976 9044 +68
==========================================
+ Hits 6896 6960 +64
- Misses 1652 1655 +3
- Partials 428 429 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aarmam
force-pushed
the
feature/list-consent-sessions
branch
from
26a6230 to
0cc8f84
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
4 times, most recently
from
f3fee3a to
b918410
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
2 times, most recently
from
e38a27a to
319ba6a
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
4 times, most recently
from
c56c5f2 to
76cf185
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
3 times, most recently
from
db77826 to
5f9223b
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
5 times, most recently
from
a8596e4 to
e73baaf
Compare
aeneasr
reviewed
Nov 1, 2022
aarmam
force-pushed
the
feature/list-consent-sessions
branch
from
e73baaf to
4c29937
Compare
aarmam
force-pushed
the
feature/list-consent-sessions
branch
3 times, most recently
from
6298d9d to
1b307ba
Compare
aeneasr
force-pushed
the
feature/list-consent-sessions
branch
from
1b307ba to
20d5bbc
Compare
harnash
pushed a commit
to Wikia/ory-hydra
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces feature to list subject consent sessions by session id.
Use case:
When authentication is initiated without
promptparameter from multiple devices, we would like to distinguish in what session was the consent given.Current situation:
GET /oauth2/auth/sessions/consent returns single consent and it references to the session id, where the consent was initially given. Furthermore if logout is performed from device initially gave the consent, the reference to login session id is cleared.
If
prompt=consentwere to be used, separate consents with separate session id would be returned and you would not have same problems. So this endpoint behaves differently in relation to how login session id is referenced.Proposed solution:
Add additional query parameter
login_session_idfor GET /oauth2/auth/sessions/consent to return consents related to requested session id.This solution does not change how login session id is referenced in result.
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security. vulnerability, I
confirm that I got green light (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments
Tests and documentation will be commited after inital acceptance of the proposed feature.