Status

READY

Description

The code generator for arrays outputs ambiguous types, and breaks for nullable array items.
Currently, the generated code looks like: string | null[]
This is interpreted as "string or an array of null", which is incorrect.
With this fix, the generated code is: (string | null)[]

This change wraps all array types in parenthesis (()). This is not necessarily needed for a single type, but it causes no harm, avoids any ambiguity, and avoids the need for more complex changes to the code generator.

I also added a regression test that fails to compile without this fix. I didn't see an existing pattern for regression tests so I came up with something. Let me know if you'd prefer a different approach.

Related PRs

n/a

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

Note See tests for complete example.

1. Create a schema like:

    nullable_items:
      type: array
      items:
        type: string
        nullable: true

2. Generate code, attempt to assign a value to the type, see error:

   TS2322: Type '[string]' is not assignable to type 'string | null[]'.   Type '[string]' is not assignable to type 'null[]'.     Type 'string' is not assignable to type 'null'.