Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(defineModel): reuse useVModel composable for generics where the type is T | T[] #998

Merged
merged 4 commits into from
Jul 4, 2024
Merged

revert(defineModel): reuse useVModel composable for generics where the type is T | T[] #998

merged 4 commits into from
Jul 4, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Jul 4, 2024 •
edited
Loading

Part of #994

Proposed Changes

  • readd a simplified useVModel composable
  • revert defineModel with useVModel for specific two-way-binded propertes with generics where the type is T | T[]
  • fix some props

@mlmoravek mlmoravek added the bug Something isn't working label Jul 4, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 4, 2024 •
edited
Loading

✅ Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit ee6b844
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6686b44a3eb790000883ba3b
😎 Deploy Preview https://deploy-preview-998--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek mentioned this pull request Jul 4, 2024
Open
@mlmoravek mlmoravek changed the title Revert/994/use v model revert(defineModel): resuse useVModel composable for generics where the type is T | T[] Jul 4, 2024
@mlmoravek mlmoravek changed the title revert(defineModel): resuse useVModel composable for generics where the type is T | T[] revert(defineModel): reuse useVModel composable for generics where the type is T | T[] Jul 4, 2024
@mlmoravek mlmoravek merged commit c00abf5 into develop Jul 4, 2024
9 checks passed
@mlmoravek mlmoravek deleted the revert/994/useVModel branch July 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlmoravek