Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimpicker): fix inline value edit | make picker props reactive #932

Merged
merged 1 commit into from
May 28, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #922

Proposed Changes

  • Remove this leftover from Option API to Composition API refactoring
  • Enhance timepicker hourFormat prop type
  • Fix datetimepicker pm/am reference by making timepicker and datepicker props reactive

@mlmoravek mlmoravek added the bug Something isn't working label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 43f59b2
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6655e3ced081d800084c14f4
😎 Deploy Preview https://deploy-preview-932--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek merged commit 1e93773 into develop May 28, 2024
7 checks passed
@mlmoravek mlmoravek deleted the bug/922/datetimepicker-inlineedit-error branch May 28, 2024 14:12
@Lahaxa
Copy link

Lahaxa commented Jun 2, 2024

Thanks for the fix! I read it's fixed but not released, any idea when we it will be released? https://framagit.org/framasoft/mobilizon/-/issues/1443

@mlmoravek
Copy link
Member Author

@Lahaxa I will check if we have any other potential issues and PR to include in the release and will make the release soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datetimepicker: Editing directly the datetime value does nothing
2 participants