Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): fix useProviderParent composable childItems type problem #897

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(menu): fix useProviderParent composable childItems type problem #897

merged 2 commits into from
Apr 16, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Apr 13, 2024 •
edited
Loading

Fixes #885

Proposed Changes

  • add UnwrapNestedRefs type wrapper for childItems in useProviderParent composable

@mlmoravek mlmoravek added the bug Something isn't working label Apr 13, 2024
@mlmoravek mlmoravek changed the title fix(menu): fix useProviderParent childItems type problem fix(menu): fix useProviderParent composable childItems type problem Apr 13, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 13, 2024 •
edited
Loading

✅ Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit e824427
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/661afa0953f52000089ded2e
😎 Deploy Preview https://deploy-preview-897--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Apr 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 13.71%. Comparing base (484cfe8) to head (e824427).
Report is 44 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/components/menu/Menu.vue 0.00% 1 Missing and 1 partial ⚠️
...ackages/oruga/src/composables/useParentProvider.ts 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop     #897       +/-   ##
============================================
- Coverage    56.71%   13.71%   -43.01%     
============================================
  Files           30      110       +80     
  Lines         1511     5279     +3768     
  Branches       544     1942     +1398     
============================================
- Hits           857      724      -133     
- Misses         654     3622     +2968     
- Partials         0      933      +933
Flag Coverage Δ
oruga-next 13.71% <40.00%> (-43.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit b9656a6 into oruga-ui:develop Apr 16, 2024
6 of 9 checks passed
@mlmoravek mlmoravek deleted the bug/menu/value_undefined branch April 16, 2024 06:25
@swirlds-automation swirlds-automation mentioned this pull request Aug 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error undefined value when clicking menu item
1 participant
@mlmoravek