Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helper): remove unintended unref function #834

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix(helper): remove unintended unref function #834

merged 1 commit into from
Mar 4, 2024

Conversation

mlmoravek
Copy link
Member

Fixes #823

Proposed Changes

  • remove unref from isDefined helper
  • add value really change check for defineClasses watcher

@mlmoravek mlmoravek added the bug Something isn't working label Mar 2, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 2, 2024 •
edited
Loading

✅ Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 9454c8e
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65e31dbd2ecc360008970dac
😎 Deploy Preview https://deploy-preview-834--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Mar 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 0.20%. Comparing base (484cfe8) to head (9454c8e).
Report is 4 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/composables/defineClasses.ts 0.00% 2 Missing and 2 partials ⚠️
packages/oruga/src/utils/helpers.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #834       +/-   ##
===========================================
- Coverage    56.71%   0.20%   -56.51%     
===========================================
  Files           30     108       +78     
  Lines         1511    5294     +3783     
  Branches       544    1921     +1377     
===========================================
- Hits           857      11      -846     
- Misses         654    4168     +3514     
- Partials         0    1115     +1115
Flag Coverage Δ
oruga-next 0.20% <0.00%> (-56.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek mentioned this pull request Mar 2, 2024
Closed
@mlmoravek mlmoravek merged commit ed75a71 into oruga-ui:develop Mar 4, 2024
7 of 9 checks passed
@mlmoravek mlmoravek deleted the bug/defineClass-isdefined branch March 4, 2024 10:19
mlmoravek added a commit to mlmoravek/oruga that referenced this pull request Mar 9, 2024
@mlmoravek
fix(isDefined): remove unintended unref function (oruga-ui#834)
b741d17
@swirlds-automation swirlds-automation mentioned this pull request Aug 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Field: slots.default() should be called in render
1 participant
@mlmoravek