Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max supported flake8 version #2

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Set max supported flake8 version #2

merged 1 commit into from
Mar 4, 2023

Conversation

Cjkjvfnby
Copy link
Contributor

In the latest release, flake8 forbids to use of error codes produced by this plugin (4 digits), which makes the plugin hard to use. PyCQA/flake8#1759

This is a quick fix to avoid confusing troubles. Not sure that it's enough.

@orsinium if you plan to do something about it, I can try to help with ideas and code.

In the latest release flake8 forbids to use of error codes produced by this plugin (4 digits), which makes the plugin hard to use.
PyCQA/flake8#1759
@orsinium
Copy link
Member

orsinium commented Mar 4, 2023

Thank you, good catch. I remember this change in flake8 being merged and breaking quite a lot of stuff without a good reason, duh.

Let me merge it, and I'll check if I can figure something better out.

@orsinium orsinium merged commit b6767e0 into orsinium-labs:master Mar 4, 2023
@orsinium
Copy link
Member

orsinium commented Mar 4, 2023

I can't reproduce the issue locally. Can you?

image

@orsinium
Copy link
Member

orsinium commented Mar 4, 2023

Ah, I see, it doesn't allow the codes in the config. Huh, what a mess.

@orsinium
Copy link
Member

orsinium commented Mar 4, 2023

Fixed and released as 0.2.0 ✅

@Cjkjvfnby Cjkjvfnby deleted the patch-1 branch March 6, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants