[Android] Speed limit in navigation mode #8897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
|
@strump Thanks! Try to google for a gpx file from any car ride in mapped areas (maybe some are available at osm.org) and use it to feed into Android Emulator. |
biodranik
reviewed
Aug 9, 2024
| if (mCurrentSpeedLimit > 0.0) | ||
| { | ||
| Pair<String, String> speedLimitAndUnits = StringUtils.nativeFormatSpeedAndUnits(last.getSpeed()); | ||
| mSpeedValue.setText(speedAndUnits.first + " / " + speedLimitAndUnits.first); |
There was a problem hiding this comment.
Would this narrow non-breaking space look better? https://www.compart.com/en/unicode/U+202F
There was a problem hiding this comment.
It can also be used on iOS btw.
There was a problem hiding this comment.
You mean replace " / " with "\u202F/\u202F"?
There was a problem hiding this comment.
Yes, or just copy the necessary space symbol and insert it directly into the string.
Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
strump
changed the title
Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
strump
commented
Aug 14, 2024
Fixed speed value color when background is red. Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
biodranik
approved these changes
Aug 14, 2024
| // White text on red background for camera speeding | ||
| mSpeedValue.setTextColor(ContextCompat.getColor(mActivity, R.color.white_primary)); | ||
| else | ||
| // Black text for speeding if there's no camera |
There was a problem hiding this comment.
Suggested change
| // Black text for speeding if there's no camera | |
| // Red text for speeding if there's no camera |
Or you can drop these comments, the code is self-explanatory.
biodranik
approved these changes
Aug 15, 2024
android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java
Outdated
Show resolved
Hide resolved
android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java
Outdated
Show resolved
Hide resolved
…java Signed-off-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
…java Signed-off-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
meenbeese
pushed a commit
to meenbeese/organicmaps
that referenced
this pull request
Nov 28, 2024
* Changed navigation UI to show speed and speed limit with '/' separator. Signed-off-by: Sergiy Kozyr <s.trump@gmail.com> * Fixed speed limit display Signed-off-by: Sergiy Kozyr <s.trump@gmail.com> * Removed red background for speedometer Signed-off-by: Sergiy Kozyr <s.trump@gmail.com> * Renamed `isSpeedLimitExceeded` to `isSpeedCamLimitExceeded`. Fixed speed value color when background is red. Signed-off-by: Sergiy Kozyr <s.trump@gmail.com> * Update android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java Signed-off-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> * Update android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java Signed-off-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> --------- Signed-off-by: Sergiy Kozyr <s.trump@gmail.com> Signed-off-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed navigation UI to show speed and speed limit with
'/'separator (as in iOS).Q1. How to test it without having a ride in a car?
How to check it on emulator?
Expected result: speed limit should be displayed in navigation mode:
Testing:
I used GPX track Florida. Busch Gardens - Pollo Tropical.gpx to emulate city ride.