(feat): enable nested captures #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jethrokuan
force-pushed
the
feat/nested-capture
branch
from
1b1c942 to
87543bf
Compare
|
Supercedes #527 |
jethrokuan
force-pushed
the
feat/nested-capture
branch
from
017ef69 to
ce477f3
Compare
|
another issue: point isn't advanced after link insertion |
|
I'll have a look in the morning to see if I can come up with a solution for the snags. |
zaeph
force-pushed
the
feat/nested-capture
branch
from
3176271 to
49a478c
Compare
|
Re: 770a4a1. |
|
49a478c was functional, but I didn't like the implementation. Tomorrow, I'd like to our custom |
zaeph
force-pushed
the
feat/nested-capture
branch
from
1e55cbf to
c138715
Compare
jethrokuan
force-pushed
the
feat/nested-capture
branch
2 times, most recently
from
29c65d2 to
a61c42e
Compare
jethrokuan
force-pushed
the
feat/nested-capture
branch
from
a61c42e to
5c9bb92
Compare
zaeph
approved these changes
Jul 26, 2020
This was referenced Jul 26, 2020
This was referenced Jul 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the long-awaited nested-captures.
This PR introduces a number of changes:
Adds a hook to
org-capture-prepare-finalize-hook, which installsorg-roam-capture--finalizeintoorg-capture-after-finalize-hookif the capture is an Org-roam capture. This function contains key functionality for Org-roam to Do The Right Thing after specific interactive functions, such as finding the file, or inserting a link.A patch for
org-capture-finalize. Specifically, we makeorg-capture-plistvalid duringorg-capture-finalize.Many hacks that were originally in place are now replaced with nicer alternatives.