(fix): fall back to org-id search ID face computation #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the scenario where the face is reported as invalid although it is part of Org's ID files (e.g. in the agenda). Fixes #1191. This can however slow face computation a lot (when there are many org id/agenda files). Here, we choose to focus on correctness.
d12frosted
reviewed
Oct 19, 2020
| (const :tag "Apply custom faces everywhere" everywhere) | ||
| (const :tag "Do not apply custom faces" nil)) | ||
| (const :tag "Use custom faces inside Org-roam notes" t) | ||
| (const :tag "Apply custom faces everywhere" everywhere) |
There was a problem hiding this comment.
I didn't know about everywhere option. Thanks for adding information to docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the scenario where the face is reported as invalid although it is part of Org's ID files (e.g. in the agenda).
Fixes #1191.
This can however slow face computation a lot (when there are many org id/agenda files). Here, we choose to focus on correctness. To mitigate this issue, we change the default scope of application of the face to Org-roam notes only.