Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginate children inscriptions #2617

Merged
merged 22 commits into from
Nov 2, 2023
Merged

Paginate children inscriptions #2617

merged 22 commits into from
Nov 2, 2023

Conversation

lifofifoX
Copy link
Collaborator

Fixes #2578

lifofifoX
lifofifoX commented Oct 31, 2023
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
lifofifoX
lifofifoX commented Oct 31, 2023
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
raphjaph
raphjaph reviewed Oct 31, 2023
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
raphjaph
raphjaph reviewed Oct 31, 2023
View reviewed changes
src/subcommand/server.rs Outdated Show resolved Hide resolved
@casey
Copy link
Collaborator

casey commented Nov 1, 2023 •
edited by raphjaph
Loading

Did some refactoring during coding club, this is just missing some testss:

server.rs tests:

  • test for fetching /children without page
  • test for fetching /children with page
  • only first four children are displayed on /inscription
  • if more than four children are displayed, display more button

@raphjaph
Copy link
Collaborator

raphjaph commented Nov 2, 2023

@devords I just finished up the last tests. Have a look if this looks good.

casey
casey requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

src/index.rs Outdated Show resolved Hide resolved
src/templates/children.rs Outdated Show resolved Hide resolved
templates/children.html Outdated Show resolved Hide resolved
src/subcommand/server.rs Outdated Show resolved Hide resolved
casey
casey approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lifofifoX
Copy link
Collaborator Author

@raphjaph Looks great to me. Thanks for adding those tests!

@raphjaph raphjaph enabled auto-merge (squash) November 2, 2023 22:45
@raphjaph raphjaph merged commit 8e8449b into ordinals:master Nov 2, 2023
6 checks passed
popcnt1 pushed a commit to popcnt1/ord that referenced this pull request Jan 11, 2025
@lifofifoX
Add /children with pagination (ordinals#2617)
cb46aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph left review comments

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inscription page should paginate children
3 participants
@lifofifoX @casey @raphjaph