Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #145 using @spacex15 approach #154

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fix bug #145 using @spacex15 approach #154

merged 1 commit into from
Jan 11, 2022

Conversation

riojax
Copy link
Contributor

@riojax riojax commented Jan 9, 2022

Fix bug #145 using @spacex15 approach.

Also this was made:

  • Add checks to avoid crashes on vessel deleting
  • Initialize HUD variables

As EXTERNALGRAPHICS preprocessor variable isn't defined, the change on Src/Orbiter/Orbiter.cpp relies on #else and checking if gclient exists. This work well on headless sessions, but we can save this check (on headless) defining a dedicated variable.
Anyway I think that to do that is out scope of a bug fix, by that I'm using this approach and taking it account for future improves.

* Add checks to avoid crashes on vessel deleting
* Initialize HUD variables
@jarmonik jarmonik merged commit 8617056 into orbitersim:d3d9client Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants