Fix bug #145 using @spacex15 approach #154
Merged
+15
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #145 using @spacex15 approach.
Also this was made:
As EXTERNALGRAPHICS preprocessor variable isn't defined, the change on Src/Orbiter/Orbiter.cpp relies on #else and checking if gclient exists. This work well on headless sessions, but we can save this check (on headless) defining a dedicated variable.
Anyway I think that to do that is out scope of a bug fix, by that I'm using this approach and taking it account for future improves.