Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup code #161

Merged
merged 1 commit into from
Oct 11, 2019
Merged

refactor: cleanup code #161

merged 1 commit into from
Oct 11, 2019

Conversation

rlespinasse
Copy link
Contributor

on

  • Redundant import alias
  • Redundant parentheses
  • Unnecessary semicolon
  • Type can be omitted

@codecov
Copy link

codecov bot commented Oct 10, 2019 •
edited
Loading

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         395      395           
  Lines       10529    10529           
=======================================
  Hits         9134     9134           
  Misses       1197     1197           
  Partials      198      198
Impacted Files Coverage Δ
internal/pb-onnx/errors.go 0% <ø> (ø) ⬆️
io.go 0% <ø> (ø) ⬆️
errors.go 0% <ø> (ø) ⬆️
backend/testbackend/testreport/coverage.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0881a57...ffb51c5. Read the comment docs.

@rlespinasse rlespinasse marked this pull request as ready for review October 10, 2019 21:35
refactor: cleanup code
ffb51c5 
on
- Redundant import alias
- Redundant parentheses
- Unnecessary semicolon
- Type can be omitted
@owulveryck owulveryck merged commit eeacaa3 into oramasearch:master Oct 11, 2019
@rlespinasse rlespinasse deleted the cleanup-code branch October 11, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlespinasse @owulveryck