Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the Go-Report card #130 #135

Merged
merged 4 commits into from
Sep 22, 2019
Merged

Enhance the Go-Report card #130 #135

merged 4 commits into from
Sep 22, 2019

Conversation

fodil-a
Copy link
Contributor

@fodil-a fodil-a commented Sep 21, 2019

Fix of a big number of report-card issues (except .gitignore)

@fodil-a
Copy link
Contributor Author

fodil-a commented Sep 21, 2019

The check failed on uploading the codecov report, with this error:

Please provide an upload token from codecov.io with valid arguments

@fodil-a
Copy link
Contributor Author

fodil-a commented Sep 21, 2019 •
edited
Loading

Fixes parts of #130

@owulveryck
Copy link
Contributor

This is weird because the token is in the secrets of github.
I will have a look at it.

Thanks for this PR.

@owulveryck
Copy link
Contributor

I relaunched the job, and it is now failing on an initial step with the error
##[error]fatal: reference is not a tree: 1ca66614bc17265d1a55203fa9791006e470e9c1

does this commit exist in your branch?

@diegobernardes @blackrez it looks like GitHub actions is not that magical after all :)))))))

owulveryck
owulveryck reviewed Sep 22, 2019
View reviewed changes
backend/x/gorgonnx/softmax.go
}
return gorgonia.Sub(a1, b1)
default:
if len(n.Shape()) != 2 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot clearer.

@fodil-a
Copy link
Contributor Author

fodil-a commented Sep 22, 2019

Thanks for the fast response.

Yes, it exists here

@owulveryck
Copy link
Contributor

I put Travis back (GitHub actions may need a bit more maturity).
Some builds are failing from times to time. I opened issue #138 to track the error which may not seem to be related to the code of this PR.

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #135 into master will increase coverage by 0.03%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage    85.2%   85.24%   +0.03%     
==========================================
  Files         395      395              
  Lines       10445    10443       -2     
==========================================
+ Hits         8900     8902       +2     
+ Misses       1338     1335       -3     
+ Partials      207      206       -1
Impacted Files Coverage Δ
internal/x/images/decode.go 46.73% <ø> (ø) ⬆️
backend/x/gorgonnx/broadcast.go 35.06% <ø> (ø) ⬆️
backend/x/gorgonnx/apigen_operators.go 57.07% <ø> (ø) ⬆️
backend/x/gorgonnx/leakyrelu.go 76.05% <0%> (ø) ⬆️
decoder.go 66.43% <100%> (+0.71%) ⬆️
backend/x/gorgonnx/softmax.go 71.42% <61.53%> (+3.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d9545...d2a086f. Read the comment docs.

@owulveryck owulveryck merged commit dd634ee into oramasearch:master Sep 22, 2019
owulveryck pushed a commit that referenced this pull request Sep 29, 2019
@fodil-a @owulveryck
Enhance the Go-Report card #130 (#135)
af2e3d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owulveryck owulveryck owulveryck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fodil-a @owulveryck