Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ingress path prefixing to consolidate under a single ingress host #8

Merged

Conversation

mvandervliet
Copy link
Contributor

  • Adds support for $INGRESS_PATH on configuration script, declaring a path prefix under which the ingress rules apply
  • minor fix in web player for relative pathing

@mvandervliet mvandervliet requested a review from junior March 17, 2022 20:17
Copy link
Member

@junior junior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -53,11 +53,6 @@ echoerr "Generate patches..."

# patch the proxy service configuration
cat <<EOF > patch-proxy-configmap.yaml
# ----------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 these files are all temp and generated on the fly 🤷

@mvandervliet mvandervliet merged commit 4781201 into oracle-quickstart:main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants