-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add handler for file uploads in slack connector, update async test runner plugin, update documentation parser #2020
add handler for file uploads in slack connector, update async test runner plugin, update documentation parser #2020
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to raise this.
This CI is not in a good way here, but unfortunately I don't have time to dig into it. I think before we can merge this someone needs to take a look at it.
Of course, thanks for the project proper :). |
Currently nobody is very active here. If you have any interest into digging into this it would be much appreciated. |
Well I would like file uploads... I will have to find some time to tinker with the test suite. |
@jacobtomlinson So I think I figured out why the test suite is bombing out completely(or at least narrowed it down)
they've provided a wrapper method for this whole dance called |
In many projects I've switched from |
haven't heard of anyio before...more reading :) |
@jacobtomlinson so the anyio swap was a little more work than adding a fixture but...ci is almost all green. I made some decisions to avoid fully reworking all the event loop references in the project into anyio friendly code for the sake of trying to keep this PR to a reasonable size, but I did have to do something to stop the yelling about accessing the event loop. This probably still needs a bit of cleanup and I guess I also have docs to update too now assuming this is a step in the right direction |
Thanks for taking the time and pushing things forwards here. I'm also not sure what is going on with the Windows failures. For the docs builds it looks like the config for ReadTheDocs is out of date. Hopefully it should be a small config tweak to get it working again. |
Read the docs stuff was deprecated, what a surprise :)... Recommonmark project recomends transitioning to myst parser so...I transitioned to myst parser. There may be some slight differences I haven't noticed but the latest _build output I looked at seemed alright. |
Alright read the docs is green |
🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thank you so much for all your efforts here. If you DM me your address on Twitter I'll post you some opsdroid stickers to thank you for perservering here!
Description
Provides a handler in the slack connector per @jacobtomlinson's recommmendation in #1611
Slightly updated as the api available after recommendations has been updated.
I also have taken a shot at replacing the async test runner for the project with anyio.
I had to add an additional parameter to OpsDroid init to allow bypassing initialization of the eventloop to avoid chicken/egg problems with initializing the anyio task group in certain sync test cases i.e.
test_configration.py
Fixes #1611
Status
UNDER DEVELOPMENT
Type of change
How Has This Been Tested?
I added a test case but still trying to figure out running the suite
Checklist: