Fix the currently broken facebook connector #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cebook-fix
- name: Blue Iris
link: http://10.51.100.81/ui3.htm
icon: blue-iris.png
jacobtomlinson
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to use the facebook connector and found that it was broken. Sending a message from facebook side would result in opsdroid receiving it but then proceeding to use user_id as message's text, due to how the arguments were positioned.
I bumped the API version as well to the newest one.
I did not report an issue prior to this.
Status
READY
Type of change
How Has This Been Tested?
Simply by following instructions on setting up the facebook connector in documentation. I tested it with multiple skills and all work fine. Hello.py skill would however use the facebook's user_id instead of his actual name, but that is how this connector must have worked originally, as there doesn't seem to be a straight-forward way to get this name. If this is a problem I can look around the facebook API docs and implement it, though barely any skills use it.
Checklist: