Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #272: Prevents commenter from being assigned after PTAL comment #285

Merged
merged 3 commits into from
Aug 23, 2021

Conversation

gp201
Copy link
Contributor

@gp201 gp201 commented Aug 21, 2021

Explanation

This PR fixes #272
Prevents commenter from being assigned after PTAL comment which references the commenter.

Checklist

  • I have successfully deployed my own instance of Oppiabot.
    • You can find instructions for doing this here.
  • I have manually tested all the changes made in this PR following the manual tests matrix.

@gp201 gp201 requested review from jameesjohn and vojtechjelinek and removed request for jameesjohn August 21, 2021 15:30
@gp201 gp201 requested a review from jameesjohn August 21, 2021 15:30
@gp201
Copy link
Contributor Author

gp201 commented Aug 23, 2021

@vojtechjelinek @jameesjohn PTAL

Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oppiabot
Copy link

oppiabot bot commented Aug 23, 2021

Unassigning @vojtechjelinek since they have already approved the PR.

Copy link
Contributor

@jameesjohn jameesjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, @gp201!

@jameesjohn jameesjohn merged commit 6c7f056 into oppia:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self Assigned after PTAL comment
3 participants