Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue button changes to a conversation message when going backwards in a chapter #4076

Closed
srushtirk opened this issue Dec 30, 2021 · 14 comments · Fixed by #4259
Closed

Continue button changes to a conversation message when going backwards in a chapter #4076

srushtirk opened this issue Dec 30, 2021 · 14 comments · Fixed by #4259
Assignees
@BenHenning
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.7 Release Block...

Comments

@srushtirk
Copy link

Describe the bug
Continue button changes to a conversation message (color changes from green to white) that says 'Please continue' once the user goes backwards in a chapter. Please continue looks like a button but is not clickable. Right and left arrows also appear once gone backwards in a chapter for navigation in the lesson. It is confusing to the user whether to click the arrows or the please continue button-like message.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any topic and a chapter in that topic
  2. Go over 3 cards
  3. Go to previous card
  4. See 'Please continue' unclickable button-like message and 2 right and left arrows on the screen

Expected behavior
'Please Continue' button should not appear on the screen. Only the front and back arrows for navigation between the lessons are sufficient.

Demonstration
image

Environment

  • Device/emulator being used: Samsung Galaxy 8
  • Android or SDK version (e.g. Android 5 or SDK 21): Android 9
  • App version: 0.6-alpha-908d57b2b1

Additional context
Add any other context about the problem here.
@srushtirk srushtirk added Type: Bug Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. labels Dec 30, 2021
@yashbansal130
Copy link
Contributor

can i work on this issue?

@yashbansal130
Copy link
Contributor

@yash10019coder can i try this one?

@yash10019coder
Copy link
Contributor

You can try it but it not seems easy for a starter issue.

@chrk2205
Copy link
Contributor

if this is open can i work on it?? @srushtirk @yash10019coder

@yash10019coder
Copy link
Contributor

Assigned @chrk2205

@chrk2205
Copy link
Contributor

I have found the bug. Technically I feel that it is not a bug.
Explanation :
In the application to go to the next state ( next page ), we are using a single method which is submit answer.
In case the page does not have any questions then we are using the phrase "Please continue." to go to the next state or page.
This phrase is being shown when the previous state or page is opened.

To solve this bug one thing we can do is use the if statement while showing the page or state which I won't recommend.
@yash10019coder

@chrk2205
Copy link
Contributor

@rt4914 can you confirm if this is a bug or not??

@BenHenning
Copy link
Member

I think this requires input from our UX team before we can move forward with a technical solution since it's not actually clear what we should be changing.

@srushtirk can you follow up with UX to determine what needs to be changed here?

@BenHenning BenHenning assigned srushtirk and unassigned chrk2205 Jan 18, 2022
@BenHenning
Copy link
Member

Thanks @chrk2205. I think we'll need to wait on input from Srushti & UX before we can move forward with a fix.

@srushtirk
Copy link
Author

@om-khandade Can you provide UX inputs?

@srushtirk srushtirk added this to the Alpha MR4 milestone Feb 14, 2022
@srushtirk
Copy link
Author

Per chat with Chantel (UXD), we agree on removing the 'Please continue' message altogether and have the user rely on forward and backward arrows.

This was referenced Mar 17, 2022
Closed
Merged
@BenHenning BenHenning assigned BenHenning and unassigned chrk2205 Mar 20, 2022
@BenHenning
Copy link
Member

BenHenning commented Mar 20, 2022 •
edited
Loading

Taking this since it's time sensitive and it seems like any progress that's been completed for it hasn't been pushed.

BenHenning added a commit that referenced this issue Mar 29, 2022
@BenHenning
Post-merge fix + 2 other fixes.
859a43e 
The first fix addresses #4076 in full.

The second fix addresses what seems to be a long-standing issue with
image region selection to ensure that the region views are always
clickable when the interaction loads.
BenHenning added a commit that referenced this issue May 6, 2022
@BenHenning
Fix #4026, #4027, #4040, #4076, #4287, #4319, #4329: Fix miscellaneou…
a6c23ca 
…s bugs found while testing alpha MR4 (#4259)

* Fix for #4040.

Doesn't include test changes yet.

* Fixes for #4027.

No tests or updated documentation.

* Revert development-only caching flags.

* Lint fixes.

* Post-merge fix + 2 other fixes.

The first fix addresses #4076 in full.

The second fix addresses what seems to be a long-standing issue with
image region selection to ensure that the region views are always
clickable when the interaction loads.

* Add follow-up fixes & tests.

* Fix new test on Gradle builds.

This test corresponds to Bazel-locked functionality, so it can't pass on
Gradle in the same way.

* Fix #4319 and #4329.

* Post-merge lint fixes.

* Lint fixes, + doc & TODO udpate.
@KolliAnitha
Copy link

Verified in 0.7-alpha-6c08d882d3. No conversation message is seen on navigating back in a chapter.

@BenHenning
Copy link
Member

For searching context, this issue was found in 0.6-alpha (MR3).

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenHenning BenHenning

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.7 Release Blockers (Alpha MR4)
7 participants
@rt4914 @BenHenning @srushtirk @chrk2205 @yashbansal130 @yash10019coder @KolliAnitha