-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marquee restarts automatically in certain scenarios. #2581
Comments
can is work on this issue |
@FareesHussain @Luffy18346 can i work on this issue |
If this is still up for grab then please assign it to me @FareesHussain . |
@Prince-kushwaha any updates on this? |
@Sparsh1212 as you are assigned to 4 other issues. I would recommend you to wait for those to get merged first. |
Actually, I have initiated the PRs for the first two issues. @fsharpasharp has asked to wait for a while (comment) for these Bazel-related issues because some more research has to be done on them, so I think that will take some time to get reviewed. And I have unassigned myself from the 3rd issue. So, I currently have only 1 active issue of which I have already initiated the PR. |
@rt4914
|
@Sparsh1212 That's exactly the issue. I tried to find solution but nothing seems to work for this. Me, Akash and few more contributors have tried solving this issue in past too and we haven't been able to fix it yet. I am afraid this might need more research from your side. Also, if this really becomes hard its completely fine to un-assign yourself and move on to some other issue. |
Thank you. I will try to do a bit more research on this once again and if I will still not be able to find any fix for this, then will unassign myself. |
* Fix #4186 Uncheck all selection on developer options not working * Fix #4186 Add changes to code as suggested on code review. * Fix #4186 Undo changes on line wrap as advised by code reviewer. * Fix #2581 Marquee restarts automatically in certain scenarios. * Fix #2581 Marquee restarts automatically in certain scenarios. * Fix #2581 Marquee restarts automatically in certain scenarios. * Fix #2581 Marquee restarts automatically in certain scenarios. * Revert "Fix #4186 Undo changes on line wrap as advised by code reviewer." This reverts commit ca5bca5. * Revert "Fix #4186 Add changes to code as suggested on code review." This reverts commit 5295364. * Revert "Fix #4186 Uncheck all selection on developer options not working" This reverts commit 0cff83a. * Insert timer in OnClick listener to enable unselect during subsequent clicks. * Introduce custom translation animation logic to fix issue with the core marquee api. * Introduce custom translation animation logic to fix issue with the core marquee api. * Fix some of the failing tests. * Fix some of the failing tests. * Fix some of the failing tests, exclude MarqueeView from tests. * Revert some of the changes. * Add MarqueeView to bazel list of custom views that import resources. * Remove Marquee tests to fix some failures. * Update exploration_activity.xml to fix failing tests. * Update exploration_activity.xml to fix failing tests. * Fix failing tests. * Fix some of the failing tests. * Fix some of the failing tests. * Fix some of the failing tests. * Fix some of failing test cases. * Update magic value textViewVirtualWidth to use the device width. * Fix Buildifier issue with bazel. * Update to use Library forked to oppia as advised. * Fix custom res import issues. * Add binding adapters for "app:speed" and "app:pause". * Revert to "app" from "marquee". * Revert unnecessary file exemption. * Fix Nit. * Fix failing tests and revert from previous fix, which could not be used in alpha. * Change to pass "app" and "speed" values in code. * Fix import NIT. * Fix failing tests by updating Bazel config files to add Android-MarqueeView as external dependency. * Fix buildifier issues after bazel file changes. * Revert tests for this feature and fix NITs. * Migrate to Oppia's fork of AndroidMarquee-View remove ellipsize assertion on some tests. * Change width to matchParent on exploration_activity.xml. * Update speed and pause to animationSpeed and animationDelay respectively to make it clear. * Change Bazel workspace config to point to Oppia's official fork. * Change to click on MarqueeView as it is parent to the ToolbarTitle on ExplorationActivityTest.kt. * Add indentations to layouts and shallow_since from CI logs. * Revert shallow since. * Update shallow since. * Add class assertion tests. * Fix spacing NIT.
) ## Explanation Fixes #4709 This reverts commit 846657e from PR #4392. See #4709 (comment) for a detailed explanation for why this reversion is the correct approach. Note that this PR will be cherry-picked into the 0.10 release branch for the upcoming MR2 beta release. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only This is a mostly clean reversion of #4392, so see that PR for an idea on how marquees behaved prior to that PR (as this PR returns the app to that behavior).
) ## Explanation Fixes #4709 This reverts commit 846657e from PR #4392. See #4709 (comment) for a detailed explanation for why this reversion is the correct approach. Note that this PR will be cherry-picked into the 0.10 release branch for the upcoming MR2 beta release. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only This is a mostly clean reversion of #4392, so see that PR for an idea on how marquees behaved prior to that PR (as this PR returns the app to that behavior).
Describe the bug
In ideal case, Marquee should only start when user click on toolbar but Marquee restarts automatically in certain scenarios after Marquee stops for the first time.
To Reproduce
Steps to reproduce the behavior:
General Steps for all below mentioned cases:
Case 1:
4) Once marquee stops, pull down notification bar of your mobile from top to bottom and then pull up, you will see Marquee moving again without clicking the toolbar.
Case 2:
4) Once marquee stops, click on EditText, Marquee starts moving again. Now wait for it to stop don't do anything.
Also after the marquee stops, then press back button to close the keyboard and you will see Marquee starts moving again
Case 3:
4) Once marquee stops, click on hint button, Marquee starts moving again.
Case 4:
4) Once marquee stops, click on close button at top-left, Marquee starts moving again.
Case 5:
4) Once marquee stops, on clicking it again, Marquee won't start no matter how many times user clicks on the toolbar.
Expected behavior
Marquess effect should start only on click on the toolbar and not automatically & it should starts every time user clicks on the toolbar after marquee stops moving.
For reference please refer to this issue: #1770
The text was updated successfully, but these errors were encountered: