Skip to content

Test format_import_proto_library.bzl on Windows #1543

Open
@miaboloix

Description

Is your feature request related to a problem? Please describe.
Currently, format_import_proto_library.bzl takes advantage of Unix commands to format the import statements of certain proto files. However, these commands may not work when building with a Windows system.

Describe the solution you'd like
This issue can be solved by building the model module on a Windows system to test whether the import statements were formatted correctly. If this function breaks on a Windows system, we must look into attributes like cmd_bat and cmd_ps which may solve the issue.

Metadata

Assignees

No one assigned

    Labels

    Impact: LowLow perceived user impact (e.g. edge cases).Issue: Needs ClarificationIndicates that an issue needs more detail in order to be able to be acted upon.Z-ibtTemporary label for Ben to keep track of issues he's triaged.enhancementEnd user-perceivable enhancements.

    Type

    No type

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions