Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak readme file #9112

Merged
merged 3 commits into from
Apr 19, 2020
Merged

Tweak readme file #9112

merged 3 commits into from
Apr 19, 2020

Conversation

kevinlee12
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of #N/A.
  2. This PR does the following: [Explain here what your PR does and why]
  • Adds the CircleCI badge to the README file.
  • Removes Codeclimate coverage (since this was for the backend tests).
  • Updates the TravisCI badge to point to the new .com instance
  • Remove the Freenode chat medium reference.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays
  • Never force push. If you do, your PR will be closed.

@kevinlee12 kevinlee12 requested a review from seanlip April 19, 2020 04:33
@codecov
Copy link

codecov bot commented Apr 19, 2020 •
edited
Loading

Codecov Report

Merging #9112 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #9112   +/-   ##
========================================
  Coverage    53.73%   53.73%           
========================================
  Files          873      873           
  Lines        35759    35759           
  Branches      4243     4243           
========================================
  Hits         19213    19213           
  Misses       15603    15603           
  Partials       943      943
Flag Coverage Δ
#frontend 53.73% <ø> (ø)

seanlip
seanlip approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinlee12! I totally forgot we had an oppia channel on Freenode :P

@seanlip seanlip assigned kevinlee12 and unassigned seanlip Apr 19, 2020
@seanlip
Copy link
Member

seanlip commented Apr 19, 2020

This doesn't really need to go through Travis. Merging.

@seanlip seanlip merged commit 4e4596a into develop Apr 19, 2020
h-ARTS pushed a commit to h-ARTS/oppia that referenced this pull request Apr 19, 2020
@kevinlee12 @h-ARTS
Tweak readme file (oppia#9112)
4d1480e 
* Update year in notice

* Adjust badges

* Remove freenode irc
@seanlip seanlip deleted the add-badge branch May 9, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

Assignees

@kevinlee12 kevinlee12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlee12 @seanlip