Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Wipeout 3.4: Start using GAE user ID" #7954

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Revert "Wipeout 3.4: Start using GAE user ID" #7954

merged 1 commit into from
Nov 9, 2019

Conversation

ankita240796
Copy link
Contributor

Reverts #7823

@oppiabot
Copy link

oppiabot bot commented Nov 9, 2019

Hi, @ankita240796. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@codecov
Copy link

codecov bot commented Nov 9, 2019 •
edited
Loading

Codecov Report

Merging #7954 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #7954      +/-   ##
===========================================
- Coverage    83.97%   83.97%   -<.01%     
===========================================
  Files         1150     1150              
  Lines        68617    68606      -11     
  Branches      3913     3913              
===========================================
- Hits         57621    57610      -11     
  Misses        9660     9660              
  Partials      1336     1336
Flag Coverage Δ
#backend 100% <100%> (ø) ⬆️
#frontend 73.65% <ø> (ø) ⬆️
Impacted Files Coverage Δ
feconf.py 100% <ø> (ø) ⬆️
core/platform/users/gae_current_user_services.py 100% <100%> (ø) ⬆️
core/storage/user/gae_models.py 100% <100%> (ø) ⬆️
core/controllers/base.py 100% <100%> (ø) ⬆️
core/domain/user_services.py 100% <100%> (ø) ⬆️
core/domain/user_jobs_one_off.py 100% <100%> (ø) ⬆️
core/domain/user_query_jobs_one_off.py 100% <100%> (ø) ⬆️

@seanlip seanlip merged commit beb011a into develop Nov 9, 2019
@seanlip seanlip deleted the revert-7823-wipeout-user-id2 branch November 9, 2019 23:29
@seanlip
Copy link
Member

seanlip commented Nov 9, 2019

This is merged, please feel free to CP. /cc @ankita240796

ankita240796 added a commit that referenced this pull request Nov 10, 2019
@ankita240796
Revert "Wipeout 3.4: Start using GAE user ID (#7823)" (#7954)
c03c4fc 
This reverts commit c60361e.
This was referenced Nov 11, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@aks681 aks681 Awaiting requested review from aks681

@brianrodri brianrodri Awaiting requested review from brianrodri

@nithusha21 nithusha21 Awaiting requested review from nithusha21

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

Assignees

@vojtechjelinek vojtechjelinek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ankita240796 @seanlip @kevinlee12 @vojtechjelinek