Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch download source for CKEditor libs to GitHub for better stability. #7920

Merged
merged 3 commits into from
Nov 5, 2019

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Nov 5, 2019

Explanation

Travis CI builds are failing due to network issues downloading CKEditor libraries. This PR switches the source of those libraries to GitHub for better reliability, and in the process removes an unneeded download.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.

Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as codeowner

Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanlip
Copy link
Member Author

seanlip commented Nov 5, 2019

All e2e tests pass and so do all the CircleCI ones except the lint checks. However, I am going to merge this to unblock the build since we have a time-sensitive release deadline.

@seanlip seanlip merged commit 6ee4ef5 into develop Nov 5, 2019
@seanlip seanlip deleted the fix-ckeditor-downloads branch November 5, 2019 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants