Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

discombobulateme · 2019-11-03T21:05:16Z

Explanation

Checklist

[ x ] The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[ x ] The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
[ x ] The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
[ x ] The PR is made from a branch that's not called "develop".
[ x ] The PR has an appropriate "PROJECT: Hacktoberfest, frontend, good first issue" label (Please add this label for the first-pass review of the PR).
The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
[ x ] The PR follows the style guide.
The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

…lish Question is disable untill all requirements are fulfilled

oppiabot · 2019-11-03T21:05:17Z

Hi, @discombobulateme. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

aks681

Just one comment.

aks681 · 2019-11-04T12:48:05Z

...templates/dev/head/components/question-directives/questions-list/questions-list.directive.ts

@@ -473,6 +474,12 @@ angular.module('oppia').directive('questionsList', [
                    }
                    $uibModalInstance.close();
                  };
+                  // Checking if Question contains all requirement to enable
+                  // Save and Publish Question
+                  $scope.toggleEnableButton = function() {


Rename the function to something like isSaveButtonDisabled().

codecov · 2019-11-04T13:56:59Z

Codecov Report

Merging #7908 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #7908      +/-   ##
===========================================
- Coverage    83.98%   83.98%   -<.01%     
===========================================
  Files         1131     1131              
  Lines        68085    68087       +2     
  Branches      3828     3828              
===========================================
  Hits         57180    57180              
- Misses        9615     9617       +2     
  Partials      1290     1290

Flag	Coverage Δ
#backend	`100% <ø> (ø)`	⬆️
#frontend	`73.6% <0%> (ø)`	⬇️

Impacted Files	Coverage Δ
...ectives/questions-list/questions-list.directive.ts	`6.29% <0%> (-0.04%)`	⬇️

discombobulateme · 2019-11-04T14:02:50Z

Corrections: changed function name as asked by @aks681 and inserted a simple tooltip for the button

vinitamurthi

Looks good thanks @discombobulateme !

discombobulateme · 2019-11-05T14:01:22Z

Hi @kevinlee12 , should I make changes on this failures? Or thoes it has something to do with today's devlist post about automatic checking? Please let me know if I can do something :)

kevinlee12 · 2019-11-05T15:35:40Z

@discombobulateme Yup, this is related to the email post, please follow the instructions from there.

kevinlee12 · 2019-11-06T03:30:36Z

@discombobulateme can you please 1) pull from the latest develop 2) merge those changes into this branch and 3) push the changes? That should solve the Travis build issue, do not force push. If you run into any issues, please let us know, thanks!

discombobulateme · 2019-11-06T11:53:53Z

@kevinlee12 just done it, and had no issues

discombobulateme added 4 commits November 3, 2019 20:27

issue oppia#6482 fixed - Skill editor, Questions, button Save and Pub…

a7bfc56

…lish Question is disable untill all requirements are fulfilled

2 errors that appeared on push fixerd

02dcb61

max lenght error fixed

5cfd3e0

space error fixed

932ae56

discombobulateme requested review from aks681 and vinitamurthi as code owners November 3, 2019 21:05

kevinlee12 added the CHANGELOG: Improvements to editors and players label Nov 4, 2019

kevinlee12 assigned vinitamurthi and aks681 Nov 4, 2019

aks681 reviewed Nov 4, 2019

View reviewed changes

aks681 assigned discombobulateme Nov 4, 2019

function name corrected and tooltip added

022a2bb

vinitamurthi approved these changes Nov 4, 2019

View reviewed changes

kevinlee12 unassigned discombobulateme and vinitamurthi Nov 5, 2019

aks681 approved these changes Nov 5, 2019

View reviewed changes

kevinlee12 assigned discombobulateme and unassigned aks681 Nov 6, 2019

merging develop

06ee38f

kevinlee12 unassigned discombobulateme Nov 7, 2019

kevinlee12 added the PR: LGTM label Nov 7, 2019

kevinlee12 merged commit 950381d into oppia:develop Nov 7, 2019

seanlip mentioned this pull request Nov 10, 2019

It's a bit strange that 'save and publish question' is enabled without an interaction #6482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

discombobulateme commented Nov 3, 2019

oppiabot bot commented Nov 3, 2019

aks681 left a comment

aks681 Nov 4, 2019

discombobulateme Nov 4, 2019

codecov bot commented Nov 4, 2019 •

edited

Loading

discombobulateme commented Nov 4, 2019

vinitamurthi left a comment

discombobulateme commented Nov 5, 2019

kevinlee12 commented Nov 5, 2019

kevinlee12 commented Nov 6, 2019 •

edited

Loading

discombobulateme commented Nov 6, 2019

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

Fix part of #6482: button is disable until all requirements are fulfilled - fixed \o/ #7908

Conversation

discombobulateme commented Nov 3, 2019

Explanation

Checklist

oppiabot bot commented Nov 3, 2019

aks681 left a comment

Choose a reason for hiding this comment

aks681 Nov 4, 2019

Choose a reason for hiding this comment

discombobulateme Nov 4, 2019

Choose a reason for hiding this comment

codecov bot commented Nov 4, 2019 • edited Loading

Codecov Report

discombobulateme commented Nov 4, 2019

vinitamurthi left a comment

Choose a reason for hiding this comment

discombobulateme commented Nov 5, 2019

kevinlee12 commented Nov 5, 2019

kevinlee12 commented Nov 6, 2019 • edited Loading

discombobulateme commented Nov 6, 2019

codecov bot commented Nov 4, 2019 •

edited

Loading

kevinlee12 commented Nov 6, 2019 •

edited

Loading