Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split flag for new structure viewers #7898

Merged
merged 5 commits into from
Nov 5, 2019
Merged

Split flag for new structure viewers #7898

merged 5 commits into from
Nov 5, 2019

Conversation

aks681
Copy link
Contributor

@aks681 aks681 commented Nov 2, 2019 •
edited
Loading

Explanation

This PR splits the new structures viewer flag to ENABLE_NEW_STRUCTURE_PLAYERS and ENABLE_NEW_STRUCTURE_VIEWER_UPDATES, where the latter is used to block POST and PUT requests. This is done so that the former can be flipped in #7889 without exposing the POST and PUT endpoints.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@aks681 aks681 requested a review from seanlip November 2, 2019 19:12
@aks681 aks681 requested a review from nithusha21 as a code owner November 2, 2019 19:12
seanlip
seanlip approved these changes Nov 2, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment. Thanks!

assets/constants.ts
@@ -539,6 +539,8 @@ export = {

"ENABLE_NEW_STRUCTURE_PLAYERS": false,

"ENABLE_NEW_STRUCTURE_VIEWER_UPDATES": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a comment explaining precisely what this controls, so that other devs don't use it beyond its intended purpose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@seanlip seanlip assigned nithusha21 and aks681 and unassigned seanlip Nov 2, 2019
@codecov
Copy link

codecov bot commented Nov 2, 2019 •
edited
Loading

Codecov Report

Merging #7898 into develop will increase coverage by 10.15%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           develop    #7898       +/-   ##
============================================
+ Coverage    73.69%   83.84%   +10.15%     
============================================
  Files          899     1115      +216     
  Lines        40971    66712    +25741     
  Branches      3769     3769               
============================================
+ Hits         30193    55932    +25739     
- Misses        9524     9526        +2     
  Partials      1254     1254
Flag Coverage Δ
#backend 99.99% <100%> (?)
#frontend 73.69% <100%> (ø) ⬆️
Impacted Files Coverage Δ
assets/constants.ts 100% <ø> (ø) ⬆️
...ev/head/domain/story/StoryContentsObjectFactory.ts 82.73% <100%> (ø) ⬆️
core/controllers/story_viewer.py 100% <100%> (ø)
core/controllers/suggestion.py 100% <100%> (ø)
core/domain/user_jobs_continuous.py 100% <0%> (ø)
scripts/generate_release_updates.py 100% <0%> (ø)
core/domain/state_domain.py 100% <0%> (ø)
scripts/create_topological_sort_of_all_services.py 100% <0%> (ø)
extensions/rich_text_components/components.py 100% <0%> (ø)
core/domain/skill_domain.py 100% <0%> (ø)
... and 210 more

@aks681 aks681 removed their assignment Nov 2, 2019
nithusha21
nithusha21 approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nithusha21
Copy link
Contributor

backend tests failing though...

@nithusha21 nithusha21 assigned aks681 and unassigned nithusha21 Nov 2, 2019
@aks681 aks681 mentioned this pull request Nov 4, 2019
Closed
9 tasks
@seanlip seanlip merged commit 0134ff7 into oppia:develop Nov 5, 2019
Hudda pushed a commit to Hudda/oppia that referenced this pull request Nov 5, 2019
@aks681 @Hudda
Split flag for new structure viewers (oppia#7898)
754a625 
* Split flag

* added comment

* fixed test
@aks681 aks681 deleted the create-flag branch January 16, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithusha21 nithusha21 nithusha21 approved these changes

@seanlip seanlip seanlip approved these changes

Assignees

@aks681 aks681

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aks681 @nithusha21 @seanlip @kevinlee12