Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update authors and changelog for v2.8.6 #7861

Merged
merged 4 commits into from
Oct 28, 2019
Merged

Update authors and changelog for v2.8.6 #7861

merged 4 commits into from
Oct 28, 2019

Conversation

ankita240796
Copy link
Contributor

Explanation

Updates changelog for releasev2.8.6

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and python -m scripts.run_frontend_tests.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@oppiabot
Copy link

oppiabot bot commented Oct 28, 2019

Hi, @ankita240796. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@ankita240796 ankita240796 changed the title Update changelog and credits for releasev2.8.6 Update authors and changelog for releasev2.8.6 Oct 28, 2019
seanlip
seanlip approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankita240796!

@seanlip seanlip removed their assignment Oct 28, 2019
@codecov
Copy link

codecov bot commented Oct 28, 2019 •
edited
Loading

Codecov Report

Merging #7861 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7861   +/-   ##
========================================
  Coverage    83.89%   83.89%           
========================================
  Files         1114     1114           
  Lines        66658    66658           
  Branches      3747     3747           
========================================
  Hits         55920    55920           
  Misses        9501     9501           
  Partials      1237     1237
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.75% <ø> (ø) ⬆️

@DubeySandeep DubeySandeep merged commit 18f9c10 into oppia:develop Oct 28, 2019
@DubeySandeep DubeySandeep changed the title Update authors and changelog for releasev2.8.6 Update authors and changelog for v2.8.6 Oct 28, 2019
@ankita240796 ankita240796 deleted the update-changelog-for-releasev2.8.6 branch October 28, 2019 21:03
ankita240796 added a commit that referenced this pull request Oct 28, 2019
@ankita240796
Update authors and changelog for v2.8.6 (#7861)
4926131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ankita240796 @seanlip @DubeySandeep