-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run install_third_party_libs on start.py #7597
Conversation
Assigning @kevinlee12 for the first-pass review of this pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@DubeySandeep @seanlip @nithusha21 @ezl-13 code owner review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dockerfile changes lgtm
@nithusha21 @DubeySandeep @seanlip PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lilithxxx -- LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Explanation
Run install_third_party_libs on start.py and changed the remaining call of bash scripts to python
Checklist
python -m scripts.pre_commit_linter
andbash scripts/run_frontend_tests.sh
.