Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run install_third_party_libs on start.py #7597

Merged
merged 5 commits into from
Sep 14, 2019

Conversation

lilithxxx
Copy link
Contributor

@lilithxxx lilithxxx commented Sep 11, 2019

Explanation

Run install_third_party_libs on start.py and changed the remaining call of bash scripts to python

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@oppiabot
Copy link

oppiabot bot commented Sep 11, 2019

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12
Copy link
Contributor

@DubeySandeep @seanlip @nithusha21 @ezl-13 code owner review please

Copy link
Contributor

@EricZLou EricZLou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dockerfile changes lgtm

@lilithxxx
Copy link
Contributor Author

@nithusha21 @DubeySandeep @seanlip PTAL!

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilithxxx -- LGTM!

@seanlip seanlip removed their assignment Sep 12, 2019
@DubeySandeep DubeySandeep removed their assignment Sep 13, 2019
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@nithusha21 nithusha21 merged commit ce4440f into oppia:develop Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants