-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7540: Changes max-width value of .oppia-library-group #7582
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #7582 +/- ##
===========================================
- Coverage 83.65% 83.65% -<.01%
===========================================
Files 1105 1105
Lines 64146 64146
Branches 3629 3629
===========================================
- Hits 53661 53660 -1
- Misses 9320 9321 +1
Partials 1165 1165
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #7582 +/- ##
===========================================
- Coverage 83.65% 83.65% -<.01%
===========================================
Files 1105 1105
Lines 64146 64146
Branches 3629 3629
===========================================
- Hits 53661 53660 -1
- Misses 9320 9321 +1
Partials 1165 1165
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Explanation
Fixes #7540, changed max-width value of .oppia-library-group
I think this issue is happening because of max-width property on .oppia-library-group.
https://drive.google.com/file/d/1tUA7kPOLCNSIrPb4jzjvm2866X7Zh06N/view
(8 + 40 + 8)px + 832px + (8 + 40 + 8 )px = 944px > 928px, so I think it should be 944px instead of 928 px over here.
Checklist
python -m scripts.pre_commit_linter
andbash scripts/run_frontend_tests.sh
.