Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7540: Changes max-width value of .oppia-library-group #7582

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

DubeySandeep
Copy link
Member

Explanation

Fixes #7540, changed max-width value of .oppia-library-group

I think this issue is happening because of max-width property on .oppia-library-group.

https://drive.google.com/file/d/1tUA7kPOLCNSIrPb4jzjvm2866X7Zh06N/view

(8 + 40 + 8)px + 832px + (8 + 40 + 8 )px = 944px > 928px, so I think it should be 944px instead of 928 px over here.

image

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #7582 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7582      +/-   ##
===========================================
- Coverage    83.65%   83.65%   -<.01%     
===========================================
  Files         1105     1105              
  Lines        64146    64146              
  Branches      3629     3629              
===========================================
- Hits         53661    53660       -1     
- Misses        9320     9321       +1     
  Partials      1165     1165
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.3% <ø> (ø) ⬇️
Impacted Files Coverage Δ
...templates/dev/head/services/IdGenerationService.ts 83.33% <0%> (-16.67%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #7582 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7582      +/-   ##
===========================================
- Coverage    83.65%   83.65%   -<.01%     
===========================================
  Files         1105     1105              
  Lines        64146    64146              
  Branches      3629     3629              
===========================================
- Hits         53661    53660       -1     
- Misses        9320     9321       +1     
  Partials      1165     1165
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.3% <ø> (ø) ⬇️
Impacted Files Coverage Δ
...templates/dev/head/services/IdGenerationService.ts 83.33% <0%> (-16.67%) ⬇️

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Sep 10, 2019
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Test server] Card slider orientation issue on library page
4 participants