Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Vagrant support from codebase #7521

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Remove Vagrant support from codebase #7521

merged 5 commits into from
Sep 2, 2019

Conversation

ulloaluis
Copy link
Contributor

Explanation

It was requested of me to remove Vagrant support from the codebase due to no developers currently using Vagrant.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python -m scripts.pre_commit_linter and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@ulloaluis ulloaluis requested a review from seanlip August 30, 2019 16:29
@oppiabot
Copy link

oppiabot bot commented Aug 30, 2019

Hi, @ulloaluis. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@seanlip
Copy link
Member

seanlip commented Aug 30, 2019

@ulloaluis Please make sure to actually follow the PR checklist when you tick a box. The checklist says: "The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).", and that box is checked, but there's no label.

@seanlip seanlip removed their request for review August 30, 2019 19:55
@seanlip
Copy link
Member

seanlip commented Aug 30, 2019

/cc @lilithxxx @brianrodri FYI

@ulloaluis
Copy link
Contributor Author

@ulloaluis Please make sure to actually follow the PR checklist when you tick a box. The checklist says: "The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).", and that box is checked, but there's no label.

I refreshed the page before I opened the PR (was making sure a newly added commit went through) and it dropped my changelog and project labels but kept the same text in the PR description. I didn't expect that behavior. My bad.

@oppiabot
Copy link

oppiabot bot commented Aug 30, 2019

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #7521 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7521   +/-   ##
========================================
  Coverage    83.43%   83.43%           
========================================
  Files         1099     1099           
  Lines        63193    63193           
  Branches      3617     3617           
========================================
  Hits         52724    52724           
  Misses        9313     9313           
  Partials      1156     1156
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.28% <ø> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Aug 30, 2019 •
edited
Loading

Codecov Report

Merging #7521 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #7521   +/-   ##
========================================
  Coverage    83.43%   83.43%           
========================================
  Files         1099     1099           
  Lines        63193    63193           
  Branches      3617     3617           
========================================
  Hits         52724    52724           
  Misses        9313     9313           
  Partials      1156     1156
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 73.28% <ø> (ø) ⬆️

@seanlip seanlip mentioned this pull request Aug 30, 2019
Merged
9 tasks
kevinlee12
kevinlee12 approved these changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Aug 31, 2019
DubeySandeep
DubeySandeep reviewed Sep 1, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ulloaluis, Thanks for the PR, changes LGTM, I've one question:
should we also remove the line linked below?

oppia/.gitattributes

Lines 32 to 34 in 880662c

Vagrantfile text eol=lf

scripts/install_third_party.py
@@ -26,11 +26,6 @@

from . import common

# These two lines prevent a "IOError: [Errno socket error]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the extra newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ulloaluis
Copy link
Contributor Author

@ulloaluis, Thanks for the PR, changes LGTM, I've one question:
should we also remove the line linked below?

oppia/.gitattributes

Lines 32 to 34 in 880662c

Vagrantfile text eol=lf

Removed!

@ulloaluis ulloaluis assigned DubeySandeep and unassigned ulloaluis Sep 1, 2019
DubeySandeep
DubeySandeep approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DubeySandeep DubeySandeep merged commit 8b28d42 into oppia:develop Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

Assignees

@DubeySandeep DubeySandeep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ulloaluis @seanlip @kevinlee12 @DubeySandeep