Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7400: Fixes issues with running typescript checks #7401

Merged
merged 2 commits into from
Aug 17, 2019
Merged

Fix #7400: Fixes issues with running typescript checks #7401

merged 2 commits into from
Aug 17, 2019

Conversation

ankita240796
Copy link
Contributor

Explanation

Fixes #7400: Excludes dist folder from compilation for typescript checks to run smoothly locally.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@oppiabot
Copy link

oppiabot bot commented Aug 17, 2019

Assigning @kevinlee12 for the first-pass review of this pull request. Thanks!

@ankita240796 ankita240796 mentioned this pull request Aug 17, 2019
Closed
@ankita240796 ankita240796 changed the title Fix #7400: Fixes issues with running typescript checs Fix #7400: Fixes issues with running typescript checks Aug 17, 2019
DubeySandeep
DubeySandeep approved these changes Aug 17, 2019
View reviewed changes
Copy link
Contributor

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankita240796, Thanks for the quick fix! (LGTM)

@DubeySandeep DubeySandeep removed their assignment Aug 17, 2019
@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #7401 into develop will decrease coverage by 16.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #7401       +/-   ##
============================================
- Coverage      100%   83.11%   -16.89%     
============================================
  Files          202     1069      +867     
  Lines        23222    58465    +35243     
  Branches         0     2800     +2800     
============================================
+ Hits         23222    48592    +25370     
- Misses           0     9125     +9125     
- Partials         0      748      +748
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 71.99% <ø> (?)
Impacted Files Coverage Δ
...pic_viewer/subtopic-viewer-domain.constants.ajs.ts 100% <0%> (ø)
.../collection/SearchExplorationsBackendApiService.ts 100% <0%> (ø)
core/templates/dev/head/services/UserService.ts 60.71% <0%> (ø)
...es/dev/head/domain/skill/SkillObjectFactorySpec.ts 100% <0%> (ø)
.../domain/topic/SubtopicPageContentsObjectFactory.ts 85.42% <0%> (ø)
...ead/expressions/ExpressionSyntaxTreeServiceSpec.ts 100% <0%> (ø)
...s/dev/head/services/AssetsBackendApiServiceSpec.ts 100% <0%> (ø)
...yer-page/services/answer-classification.service.ts 86.36% <0%> (ø)
...editor-page/services/story-editor-state.service.ts 88.71% <0%> (ø)
...ore/templates/dev/head/services/PromoBarService.ts 80% <0%> (ø)
... and 857 more

3 similar comments
@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #7401 into develop will decrease coverage by 16.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #7401       +/-   ##
============================================
- Coverage      100%   83.11%   -16.89%     
============================================
  Files          202     1069      +867     
  Lines        23222    58465    +35243     
  Branches         0     2800     +2800     
============================================
+ Hits         23222    48592    +25370     
- Misses           0     9125     +9125     
- Partials         0      748      +748
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 71.99% <ø> (?)
Impacted Files Coverage Δ
...pic_viewer/subtopic-viewer-domain.constants.ajs.ts 100% <0%> (ø)
.../collection/SearchExplorationsBackendApiService.ts 100% <0%> (ø)
core/templates/dev/head/services/UserService.ts 60.71% <0%> (ø)
...es/dev/head/domain/skill/SkillObjectFactorySpec.ts 100% <0%> (ø)
.../domain/topic/SubtopicPageContentsObjectFactory.ts 85.42% <0%> (ø)
...ead/expressions/ExpressionSyntaxTreeServiceSpec.ts 100% <0%> (ø)
...s/dev/head/services/AssetsBackendApiServiceSpec.ts 100% <0%> (ø)
...yer-page/services/answer-classification.service.ts 86.36% <0%> (ø)
...editor-page/services/story-editor-state.service.ts 88.71% <0%> (ø)
...ore/templates/dev/head/services/PromoBarService.ts 80% <0%> (ø)
... and 857 more

@codecov
Copy link

codecov bot commented Aug 17, 2019

Codecov Report

Merging #7401 into develop will decrease coverage by 16.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #7401       +/-   ##
============================================
- Coverage      100%   83.11%   -16.89%     
============================================
  Files          202     1069      +867     
  Lines        23222    58465    +35243     
  Branches         0     2800     +2800     
============================================
+ Hits         23222    48592    +25370     
- Misses           0     9125     +9125     
- Partials         0      748      +748
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 71.99% <ø> (?)
Impacted Files Coverage Δ
...pic_viewer/subtopic-viewer-domain.constants.ajs.ts 100% <0%> (ø)
.../collection/SearchExplorationsBackendApiService.ts 100% <0%> (ø)
core/templates/dev/head/services/UserService.ts 60.71% <0%> (ø)
...es/dev/head/domain/skill/SkillObjectFactorySpec.ts 100% <0%> (ø)
.../domain/topic/SubtopicPageContentsObjectFactory.ts 85.42% <0%> (ø)
...ead/expressions/ExpressionSyntaxTreeServiceSpec.ts 100% <0%> (ø)
...s/dev/head/services/AssetsBackendApiServiceSpec.ts 100% <0%> (ø)
...yer-page/services/answer-classification.service.ts 86.36% <0%> (ø)
...editor-page/services/story-editor-state.service.ts 88.71% <0%> (ø)
...ore/templates/dev/head/services/PromoBarService.ts 80% <0%> (ø)
... and 857 more

@codecov
Copy link

codecov bot commented Aug 17, 2019 •
edited
Loading

Codecov Report

Merging #7401 into develop will decrease coverage by 16.89%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #7401       +/-   ##
============================================
- Coverage      100%   83.11%   -16.89%     
============================================
  Files          202     1069      +867     
  Lines        23222    58465    +35243     
  Branches         0     2800     +2800     
============================================
+ Hits         23222    48592    +25370     
- Misses           0     9125     +9125     
- Partials         0      748      +748
Flag Coverage Δ
#backend 100% <ø> (ø) ⬆️
#frontend 71.99% <ø> (?)
Impacted Files Coverage Δ
...pic_viewer/subtopic-viewer-domain.constants.ajs.ts 100% <0%> (ø)
.../collection/SearchExplorationsBackendApiService.ts 100% <0%> (ø)
core/templates/dev/head/services/UserService.ts 60.71% <0%> (ø)
...es/dev/head/domain/skill/SkillObjectFactorySpec.ts 100% <0%> (ø)
.../domain/topic/SubtopicPageContentsObjectFactory.ts 85.42% <0%> (ø)
...ead/expressions/ExpressionSyntaxTreeServiceSpec.ts 100% <0%> (ø)
...s/dev/head/services/AssetsBackendApiServiceSpec.ts 100% <0%> (ø)
...yer-page/services/answer-classification.service.ts 86.36% <0%> (ø)
...editor-page/services/story-editor-state.service.ts 88.71% <0%> (ø)
...ore/templates/dev/head/services/PromoBarService.ts 80% <0%> (ø)
... and 857 more

@ankita240796 ankita240796 merged commit e0e725a into oppia:develop Aug 17, 2019
@ankita240796 ankita240796 deleted the fix-ts branch August 17, 2019 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@kevinlee12 kevinlee12 Awaiting requested review from kevinlee12

Assignees

@kevinlee12 kevinlee12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to run typescript_test.py locally
3 participants
@ankita240796 @DubeySandeep @kevinlee12