Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript errors #7341

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

vojtechjelinek
Copy link
Contributor

Explanation

Tests are failing on develop because of TypeScript errors that arise due to a race condition.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vojtechjelinek! LGTM.

@seanlip
Copy link
Member

seanlip commented Aug 9, 2019

@DubeySandeep PTAL

@seanlip
Copy link
Member

seanlip commented Aug 9, 2019

Merging to unbreak develop. Thanks @vojtechjelinek!

@seanlip seanlip merged commit 1a0f5b5 into oppia:develop Aug 9, 2019
seanlip added a commit that referenced this pull request Aug 10, 2019
seanlip added a commit that referenced this pull request Aug 10, 2019
* Revert "Add null to calls to navigateToMainTab (#7341)"

This reverts commit 1a0f5b5.

* Revert "Fix typescript errors and add a new config file for compilation checks (#7293)"

This reverts commit 9c272c4.
@vojtechjelinek vojtechjelinek deleted the typescript-fix branch January 26, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants