Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#Fixes 7125 Fixing unresponsive sidebar toggle in mobile view #7265

Merged
merged 1 commit into from
Aug 4, 2019
Merged

#Fixes 7125 Fixing unresponsive sidebar toggle in mobile view #7265

merged 1 commit into from
Aug 4, 2019

Conversation

Showtim3
Copy link
Contributor

@Showtim3 Showtim3 commented Aug 1, 2019 •
edited
Loading

Explanation

Fixes #7125 So this is a pretty straight forward issue. ctrl was written as crtl and hence the unresponsive sidebar. After fixing the typo, the sidebar is working fine. I have tested it on a couple of pages like /splash, libray page, contact page etc. It's working fine with this fix.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "PROJECT: ..." label (Please add this label for the first-pass review of the PR).
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@oppiabot
Copy link

oppiabot bot commented Aug 1, 2019

Hi, @Showtim3. This pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Please add this label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@Showtim3
Copy link
Contributor Author

Showtim3 commented Aug 1, 2019

@vojtechjelinek @NishealJ @Jamesjay4199 PTAL
Thanks!

@NishealJ
Copy link
Contributor

NishealJ commented Aug 1, 2019

LGTM! I hope you have done the needed testing,
@DubeySandeep PTAL Thanks!

@NishealJ NishealJ requested a review from DubeySandeep August 1, 2019 19:20
@NishealJ NishealJ removed their assignment Aug 1, 2019
DubeySandeep
DubeySandeep approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Showtim3, Thanks for the PR, code changes LGTM! (I haven't tested the UI)

vojtechjelinek
vojtechjelinek approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

vojtechjelinek
vojtechjelinek approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@vojtechjelinek vojtechjelinek removed their assignment Aug 3, 2019
@DubeySandeep
Copy link
Member

@Jamesjay4199, Can you please review this PR?

jameesjohn
jameesjohn approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@jameesjohn jameesjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks @Showtim3

@jameesjohn jameesjohn removed their assignment Aug 3, 2019
@DubeySandeep
Copy link
Member

@Jamesjay4199, Have you done the manual UI review as well?

@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #7265 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7265      +/-   ##
===========================================
- Coverage    89.39%   89.38%   -<.01%     
===========================================
  Files         1206     1206              
  Lines        97987    97987              
  Branches      2635     2635              
===========================================
- Hits         87586    87585       -1     
- Misses        9766     9767       +1     
  Partials       635      635
Flag Coverage Δ
#backend 98.81% <ø> (ø) ⬆️
#frontend 71.03% <ø> (ø) ⬇️
Impacted Files Coverage Δ
...v/head/domain/utilities/LanguageUtilServiceSpec.ts 91.84% <0%> (-2.04%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Aug 3, 2019

Codecov Report

Merging #7265 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #7265      +/-   ##
===========================================
- Coverage    89.39%   89.38%   -<.01%     
===========================================
  Files         1206     1206              
  Lines        97987    97987              
  Branches      2635     2635              
===========================================
- Hits         87586    87585       -1     
- Misses        9766     9767       +1     
  Partials       635      635
Flag Coverage Δ
#backend 98.81% <ø> (ø) ⬆️
#frontend 71.03% <ø> (ø) ⬇️
Impacted Files Coverage Δ
...v/head/domain/utilities/LanguageUtilServiceSpec.ts 91.84% <0%> (-2.04%) ⬇️

@jameesjohn
Copy link
Contributor

I've done the UI testing and it works.

@jameesjohn
Copy link
Contributor

I think this is ready to be merged @DubeySandeep.

@jameesjohn jameesjohn removed their assignment Aug 4, 2019
@DubeySandeep DubeySandeep merged commit 041f148 into oppia:develop Aug 4, 2019
@NishealJ NishealJ mentioned this pull request Aug 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameesjohn jameesjohn jameesjohn approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

Assignees
No one assigned
Labels
frontend PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Un-responsive toggle navigation in mobile view
7 participants
@Showtim3 @NishealJ @DubeySandeep @jameesjohn @vojtechjelinek @nithusha21 @aks681