Remove oppia module export. #7259
Conversation
YashJipkate
requested review from
aks681,
ankita240796,
brianrodri,
DubeySandeep,
jameesjohn,
kevinlee12,
nithusha21,
prasanna08,
seanlip and
sophiewu6
as code owners
YashJipkate
requested review from
vinitamurthi and
vojtechjelinek
as code owners
There was a problem hiding this comment.
Thanks @YashJipkate. Just one inline comment. I also think @vojtechjelinek should take a look at the webpack config file, but other than that, we can merge this PR after he and I give approval (you don't need to wait for the other codeowners).
Thanks!
| var oppia = require('AppInit.ts').module; | ||
|
|
||
| oppia.factory('ExpressionParserService', ['$log', function($log) { | ||
| angular.module('oppia').factory('ExpressionParserService', ['$log', function($log) { |
There was a problem hiding this comment.
This is a generated file, so make sure that the generator script in this folder is configured to generate this new text properly. See the README in this folder.
It might be nice to also add a comment at the top of the file saying "DO NOT MODIFY THIS FILE DIRECTLY, see XXX instead."
There was a problem hiding this comment.
Modified the create_expression_parser script.
| @@ -187,7 +187,7 @@ oppia.directive('tutorCard', [ | |||
|
|
|||
| $scope.toggleShowPreviousResponses = function() { | |||
| $scope.arePreviousResponsesShown = | |||
| !$scope.arePreviousResponsesShown; | |||
| !$scope.arePreviousResponsesShown; | |||
There was a problem hiding this comment.
This should be indented by 2. Put a '(' ')' around it if needed.
|
Please note the Travis failures. |
* Half * half * half * Cleanup * Cleanup * Cleanup * Break line * Remove var oppia from App.ts * Removed var oppia * Removed var oppia * Partial lint * FIx FE * Partial lint * Partial lint * Partial lint * Partial lint * Fix learner dashboard * Partial lint * Lint * Address review * Update package.json * Update package.json * Revert "Update package.json" This reverts commit 0530a8c. * Revert "Update package.json" This reverts commit c18ff6a. * Revert "Address review" This reverts commit 333e7fa. * Revert package.json
Explanation
Removes the
var oppia = require('AppInit.ts')statements. This PR sits on top of #7254Checklist
-These should run automatically, but if not, you can manually trigger them locally using
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.