Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade more services to Angular 8 - IV #7223

Merged
merged 200 commits into from
Jul 26, 2019
Merged

Upgrade more services to Angular 8 - IV #7223

merged 200 commits into from
Jul 26, 2019

Conversation

YashJipkate
Copy link
Contributor

@YashJipkate YashJipkate commented Jul 25, 2019

Explanation

This PR upgrades:

  • AnswerGroupsCacheService
  • ChangeObjectFactory
  • CollectionPlaythroughObjectFactory
  • CollectionRightsObjectFactory
  • CreatorDashboardBackendApiService
  • CreatorDashboardBackendApiService
  • EndExplorationRulesService
  • GraphDetailService
  • GraphUtilsService
  • GuestCollectionProgressObjectFactory
  • ImageClickInputRulesService
  • ImprovementActionButtonObjectFactory
  • InteractionDetailsCacheService
  • LearnerDashboardBackendApiService
  • LearnerDashboardIdsBackendApiService
  • LearnerParamsService
  • MathExpressionInputRulesService
  • ParamChangeObjectFactory
  • ParamTypeObjectFactory
  • PlaythroughIssueObjectFactory
  • SkillDifficultyObjectFactory
  • ThreadStatusDisplayService
  • VersionTreeService
  • WinnowingPreprocessingService

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12
Copy link
Contributor

@seanlip @vojtechjelinek, ptal!

@kevinlee12 kevinlee12 removed their assignment Jul 25, 2019
@YashJipkate YashJipkate reopened this Jul 25, 2019
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @YashJipkate! No comments.

@YashJipkate YashJipkate reopened this Jul 25, 2019
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinlee12
Copy link
Contributor

Hi @seanlip, tests pass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants