-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade more services to Angular 8 - IV #7223
Conversation
This reverts commit 13424bf.
FeedbackThreadSummaryObjectFactory
...es/dev/head/pages/exploration-editor-page/editor-tab/services/answer-groups-cache.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@seanlip @vojtechjelinek, ptal! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @YashJipkate! No comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @seanlip, tests pass! |
Explanation
This PR upgrades:
Checklist
python scripts/pre_commit_linter.py
andbash scripts/run_frontend_tests.sh
.