Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7087: Add log for "contains no units" SyntaxError #7157

Merged
merged 18 commits into from
Jul 18, 2019
Merged

Fix #7087: Add log for "contains no units" SyntaxError #7157

merged 18 commits into from
Jul 18, 2019

Conversation

kevintab95
Copy link
Member

Explanation

Fixes #7087: Added a try-catch to additionally log the actual input string and parameter passed to math.unit(). This information will help us reproduce the issue.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

Kevin Thomas added 15 commits July 5, 2016 02:43
Fixes oppia#2197 and oppia#2195
9a8da89
fix e2e error (library)
69f6bac
Use URL as constants
0762dec
Constants in all caps
9111f18
Merge remote-tracking branch 'upstream/develop' into develop
b401763
Fix linting issue
28270eb
Merge remote-tracking branch 'upstream/develop' into develop
c970857
Merge remote-tracking branch 'upstream/develop' into develop
cf7ffb3 
Merge upstream/develop to develop
Merge remote-tracking branch 'upstream/develop' into develop
bc8e8e0
Merge remote-tracking branch 'upstream/develop' into develop
92b6e27
Merge remote-tracking branch 'upstream/develop' into develop
023f1bb
Merge remote-tracking branch 'upstream/develop' into develop
ea83655
Merge remote-tracking branch 'upstream/develop' into develop
f79a51c
Merge remote-tracking branch 'upstream/develop' into develop
3cd1341
adds log for oppia#7087
6031a26
@kevintab95 kevintab95 requested review from seanlip and nithusha21 July 17, 2019 07:54
seanlip
seanlip approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kevintab95! But one question: do you need any info about earlierInputString?

@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #7157 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7157      +/-   ##
===========================================
- Coverage    86.92%   86.92%   -0.01%     
===========================================
  Files          941      941              
  Lines        85507    85511       +4     
  Branches      2727     2727              
===========================================
+ Hits         74331    74332       +1     
- Misses       11176    11179       +3
Impacted Files Coverage Δ
...its/directives/NumberWithUnitsValidationService.ts 94.54% <100%> (-5.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2a0db...2471800. Read the comment docs.

@kevintab95
Copy link
Member Author

I guess laterInputString can be derived from laterInput. I've removed that. Thanks!

vojtechjelinek
vojtechjelinek approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanlip
Copy link
Member

seanlip commented Jul 17, 2019

Hi @kevintab95 -- just to clarify, I meant, "should we also log earlierInputString" as opposed to "should we remove laterInputString"...

kevinlee12
kevinlee12 approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12
Copy link
Contributor

@seanlip, can this be merged as-is or do you want more work on this?

@seanlip
Copy link
Member

seanlip commented Jul 17, 2019

Let's not merge it just yet -- I want to get confirmation that @kevintab95 is happy with it (in light of my last comment). If he is then we can merge it. Thanks for checking!

@kevintab95
Copy link
Member Author

Oh I missed that, I see what you mean now. I've logged earlierInput as well. Thanks @seanlip!

seanlip
seanlip approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kevintab95 !

@DubeySandeep
Copy link
Member

@nithusha21, I'm not sure whether I should add "Bug fixes" label to this PR. Do you have any suggestion?

@seanlip
Copy link
Member

seanlip commented Jul 18, 2019

Hm good point, I put it under "infrastructural changes" as it's adding logging. Thanks for checking! Will merge it now.

@seanlip seanlip merged commit 1ec3f47 into oppia:develop Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@nithusha21 nithusha21 Awaiting requested review from nithusha21

Assignees

@kevintab95 kevintab95

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError: "2" contains no units
5 participants
@kevintab95 @seanlip @kevinlee12 @DubeySandeep @vojtechjelinek