Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #6387: Remove tag_regex, invalid_parameter_names, show_trainable_unresolved_answers #7140

Merged
merged 7 commits into from
Jul 16, 2019
Merged

Fixes part of #6387: Remove tag_regex, invalid_parameter_names, show_trainable_unresolved_answers #7140

merged 7 commits into from
Jul 16, 2019

Conversation

jameesjohn
Copy link
Contributor

Explanation

Fixes part of #6387: Remove tag_regex, invalid_parameter_names, show_trainable_unresolved_answers from collection editor and exploration editor

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

vojtechjelinek
vojtechjelinek approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameesjohn jameesjohn requested a review from apb7 as a code owner July 15, 2019 07:13
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #7140 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7140      +/-   ##
===========================================
+ Coverage    98.05%   98.06%   +<.01%     
===========================================
  Files          377      377              
  Lines        63176    63082      -94     
===========================================
- Hits         61948    61860      -88     
+ Misses        1228     1222       -6
Impacted Files Coverage Δ
core/controllers/collection_editor.py 100% <ø> (ø) ⬆️
feconf.py 99.45% <ø> (-0.01%) ⬇️
core/controllers/editor.py 100% <ø> (ø) ⬆️
core/domain/exp_domain.py 94.08% <100%> (ø) ⬆️
core/domain/user_services.py 100% <100%> (ø) ⬆️
core/domain/collection_domain.py 100% <100%> (ø) ⬆️
core/domain/stats_jobs_one_off.py 53.98% <0%> (-3.1%) ⬇️
core/domain/stats_jobs_one_off_test.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a98b3...3fc971d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited
Loading

Codecov Report

Merging #7140 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7140      +/-   ##
===========================================
+ Coverage    98.05%   98.06%   +<.01%     
===========================================
  Files          377      377              
  Lines        63176    63082      -94     
===========================================
- Hits         61948    61860      -88     
+ Misses        1228     1222       -6
Impacted Files Coverage Δ
core/controllers/collection_editor.py 100% <ø> (ø) ⬆️
feconf.py 99.45% <ø> (-0.01%) ⬇️
core/controllers/editor.py 100% <ø> (ø) ⬆️
core/domain/exp_domain.py 94.08% <100%> (ø) ⬆️
core/domain/user_services.py 100% <100%> (ø) ⬆️
core/domain/collection_domain.py 100% <100%> (ø) ⬆️
core/domain/stats_jobs_one_off.py 53.98% <0%> (-3.1%) ⬇️
core/domain/stats_jobs_one_off_test.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a98b3...3fc971d. Read the comment docs.

@vojtechjelinek vojtechjelinek removed the request for review from apb7 July 15, 2019 08:33
@vojtechjelinek
Copy link
Contributor

@kevinlee12 @nithusha21 @DubeySandeep @aks681 Code owner review, please.

kevinlee12
kevinlee12 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Jul 15, 2019
nithusha21
nithusha21 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nithusha21 nithusha21 removed their assignment Jul 15, 2019
@aks681 aks681 removed their assignment Jul 15, 2019
@DubeySandeep DubeySandeep assigned seanlip and unassigned DubeySandeep Jul 16, 2019
seanlip
seanlip approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Sorry for the delay!

@seanlip seanlip merged commit a5cacf6 into oppia:develop Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aks681 aks681 aks681 approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@seanlip seanlip seanlip approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

Assignees

@seanlip seanlip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jameesjohn @vojtechjelinek @kevinlee12 @seanlip @nithusha21 @DubeySandeep @aks681