Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: Build error in develop #7137

Merged
merged 4 commits into from
Jul 14, 2019
Merged

Fixes: Build error in develop #7137

merged 4 commits into from
Jul 14, 2019

Conversation

NishealJ
Copy link
Contributor

@NishealJ NishealJ commented Jul 13, 2019 •
edited by apb7
Loading

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@NishealJ NishealJ mentioned this pull request Jul 13, 2019
Closed
8 tasks
@NishealJ NishealJ self-assigned this Jul 13, 2019
kevinlee12
kevinlee12 approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

apb7
apb7 reviewed Jul 14, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NishealJ, thanks for the PR. Left a comment, ptal. Also, while you're pulling changes from different PRs, please do the changes made in PR #7136 so that we have a single PR for the fixes. Thanks!

package-lock.json Outdated Show resolved Hide resolved
@kevinlee12
Copy link
Contributor

Somehow Github is not reporting the correct statuses:

Fronted - PASS: https://circleci.com/gh/NishealJ/oppia/565
Setup - PASS: https://circleci.com/gh/NishealJ/oppia/564

@NishealJ
Copy link
Contributor Author

Somehow Github is not reporting the correct statuses:

Fronted - PASS: https://circleci.com/gh/NishealJ/oppia/565
Setup - PASS: https://circleci.com/gh/NishealJ/oppia/564

Thanks, @kevinlee12, tests are now running in oppia's instance

@NishealJ
Copy link
Contributor Author

Hi @NishealJ, thanks for the PR. Left a comment, ptal. Also, while you're pulling changes from different PRs, please do the changes made in PR #7136 so that we have a single PR for the fixes. Thanks!

Also @apb7, After the pull, I've removed the I/O try-catch block and updated only app.yaml -> app_dev.yaml because the addition of exceptions was in discussion. Can we keep your open and the I/O expectation from that PR?

@kevinlee12 kevinlee12 assigned apb7 and unassigned NishealJ Jul 14, 2019
@NishealJ
Copy link
Contributor Author

Hi @DubeySandeep,
Sorry, I've pulled your PR and added it here, it was blocking me and was easy to debug the build-errors. Thanks for the fix!

@apb7
Copy link
Contributor

apb7 commented Jul 14, 2019

Also @apb7, After the pull, I've removed the I/O try-catch block and updated only app.yaml -> app_dev.yaml because the addition of exceptions was in discussion. Can we keep your open and the I/O expectation from that PR?

Please pull the complete PR changes (That PR is already LGTM). Thanks!

@apb7 apb7 mentioned this pull request Jul 14, 2019
Closed
8 tasks
@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #7137 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7137   +/-   ##
========================================
  Coverage    98.06%   98.06%           
========================================
  Files          377      377           
  Lines        63086    63086           
========================================
  Hits         61864    61864           
  Misses        1222     1222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2858751...a9787ff. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 14, 2019 •
edited
Loading

Codecov Report

Merging #7137 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #7137   +/-   ##
========================================
  Coverage    98.06%   98.06%           
========================================
  Files          377      377           
  Lines        63086    63086           
========================================
  Hits         61864    61864           
  Misses        1222     1222

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2858751...51e7578. Read the comment docs.

apb7
apb7 approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @NishealJ! Nice work :)

@apb7 apb7 assigned vojtechjelinek and unassigned apb7 Jul 14, 2019
vojtechjelinek
vojtechjelinek approved these changes Jul 14, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vojtechjelinek vojtechjelinek merged commit c36eff3 into oppia:develop Jul 14, 2019
@apb7 apb7 mentioned this pull request Jul 14, 2019
Closed
8 tasks
@DubeySandeep
Copy link
Member

I'll have to cherry-pick this pr for the current release as after cherry-picking few PRs from develop the release branch started failing lint tests.

DubeySandeep pushed a commit that referenced this pull request Jul 15, 2019
@DubeySandeep
Fixes: Build error in develop (#7137)
1d3cf54 
* Initial commit

* Change app.yaml to app_dev

* Revert Package lock

* Update third_party_size_check.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apb7 apb7 apb7 approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@seanlip seanlip Awaiting requested review from seanlip

Assignees

@vojtechjelinek vojtechjelinek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NishealJ @kevinlee12 @apb7 @DubeySandeep @vojtechjelinek