Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7127: Fix invalid html conversion process to avoid extra lines #7128

Merged
merged 5 commits into from
Jul 15, 2019
Merged

Fix #7127: Fix invalid html conversion process to avoid extra lines #7128

merged 5 commits into from
Jul 15, 2019

Conversation

ankita240796
Copy link
Contributor

@ankita240796 ankita240796 commented Jul 11, 2019 •
edited
Loading

Explanation

Fixes #7127:

  • Updates conversion of ol/ul tags to avoid adding an extra list element for empty lines.
  • Updates conversion of content without any tag to remove extra newline characters.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@ankita240796 ankita240796 requested a review from seanlip as a code owner July 11, 2019 07:42
@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #7128 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7128      +/-   ##
===========================================
+ Coverage    98.06%   98.06%   +<.01%     
===========================================
  Files          377      377              
  Lines        63086    63090       +4     
===========================================
+ Hits         61864    61868       +4     
  Misses        1222     1222
Impacted Files Coverage Δ
core/domain/html_validation_service_test.py 100% <ø> (ø) ⬆️
core/domain/html_validation_service.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f52947f...1b44563. Read the comment docs.

@ankita240796 ankita240796 mentioned this pull request Jul 11, 2019
Closed
@ankita240796 ankita240796 changed the title Fix #7127: Fix extra element being added in list Fix #7127: Fix invalid html conversion process to avoid extra lines Jul 11, 2019
bansalnitish
bansalnitish approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@bansalnitish bansalnitish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for fixing this @ankita240796!

nithusha21
nithusha21 approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@seanlip seanlip merged commit ef1747a into oppia:develop Jul 15, 2019
@ankita240796 ankita240796 deleted the fix-list branch July 15, 2019 05:22
DubeySandeep pushed a commit that referenced this pull request Jul 15, 2019
@ankita240796 @DubeySandeep
Fix #7127: Fix invalid html conversion process to avoid extra lines (#…
507ca5e 
…7128)

* Fix extra element being added in list

* Fix comment

* Add test case

* Fix extra lines

* Update list fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bansalnitish bansalnitish bansalnitish approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@seanlip seanlip seanlip approved these changes

@DubeySandeep DubeySandeep Awaiting requested review from DubeySandeep

Assignees

@seanlip seanlip

@DubeySandeep DubeySandeep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extra Lines and List Items Added on Save Draft (Develop branch)
5 participants
@ankita240796 @seanlip @nithusha21 @bansalnitish @DubeySandeep