Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5069: Remove $parent from codebase. #7110

Merged
merged 16 commits into from
Jul 9, 2019
Merged

Fix #5069: Remove $parent from codebase. #7110

merged 16 commits into from
Jul 9, 2019

Conversation

YashJipkate
Copy link
Contributor

Explanation

Fixes #5069. Removes $parent from codebase.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

seanlip
seanlip approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YashJipkate, great job, it's nice to see $parent finally get removed once and for all!

One question. How did you manually test this -- can you describe in detail? Did you manually check every directive here? This is a place where regressions can easily arise, so it's important to be careful.

package-lock.json Outdated Show resolved Hide resolved
@seanlip seanlip removed their assignment Jul 7, 2019
@YashJipkate
Copy link
Contributor Author

Hi @seanlip, Yes I have gone through each of the directives and manually tested that the directives work as expected. Actually not much fuss was required since $parent is something used due to $scope but once you pass the bindings to the controller and use the controllerAs syntax in an isolated scope, it takes care of all the reasons that $parent was used for.
Also, if anyone could do an additional QA, they are welcome :) although I have tested and I dont think this should cause any breakage.

@YashJipkate YashJipkate closed this Jul 7, 2019
@YashJipkate YashJipkate reopened this Jul 7, 2019
kevinlee12
kevinlee12 approved these changes Jul 7, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Jul 7, 2019
apb7
apb7 approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code owner's perspective, thanks!

@apb7 apb7 removed their assignment Jul 8, 2019
vojtechjelinek
vojtechjelinek suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one thing, why the rights change to scripts/pre_commit_hook.py?

@YashJipkate
Copy link
Contributor Author

@vojtechjelinek That might have happened when I set the pre-commit hook executable manually. I don't have any idea why did this happen.

@apb7 Any ideas?

@DubeySandeep
Copy link
Member

@vojtechjelinek That might have happened when I set the pre-commit hook executable manually. I don't have any idea why did this happen.

This also happened twice with me and for me, it happened automatically and I checked out the changes manually.

DubeySandeep
DubeySandeep approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files (haven't tested the UI manually)

@YashJipkate YashJipkate closed this Jul 8, 2019
@YashJipkate YashJipkate reopened this Jul 8, 2019
@kevinlee12 kevinlee12 requested a review from vojtechjelinek July 8, 2019 18:16
@kevinlee12
Copy link
Contributor

@vojtechjelinek, PTAL for code owner, thanks!

vojtechjelinek
vojtechjelinek approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code owner's perspective. Thanks!

@vojtechjelinek vojtechjelinek merged commit 3316974 into oppia:develop Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apb7 apb7 apb7 approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@seanlip seanlip seanlip approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

Assignees

@vojtechjelinek vojtechjelinek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove $parent from HTML files
6 participants
@YashJipkate @DubeySandeep @kevinlee12 @vojtechjelinek @seanlip @apb7