Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade AngularJS Material #7097

Merged
merged 101 commits into from
Jul 23, 2019
Merged

Upgrade AngularJS Material #7097

merged 101 commits into from
Jul 23, 2019

Conversation

NishealJ
Copy link
Contributor

@NishealJ NishealJ commented Jul 5, 2019

Explanation

This PR Upgrades AngularJS Material to its latest version.
To view the status of library upgrade please visit here
For the testing doc please visit here

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@DubeySandeep
Copy link
Member

@NishealJ, Assigne this to me once you get approval from @apb7!

@DubeySandeep DubeySandeep removed their assignment Jul 22, 2019
@vinitamurthi vinitamurthi removed their assignment Jul 22, 2019
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @NishealJ.

@apb7 apb7 assigned DubeySandeep and unassigned apb7, NishealJ and vojtechjelinek Jul 22, 2019
.oppia-admin-page-card button {
max-width: 30%;
}
</style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a newline here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done Thanks!

Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as codeowner

@aks681 aks681 removed their assignment Jul 22, 2019
@seanlip seanlip merged commit 1872491 into oppia:develop Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants