Upgrade constants to Angular 8 #7066
Conversation
|
Hi @YashJipkate. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
|
Hi @YashJipkate. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
|
|
||
| angular.module('oppia').constant('VIEW_HINT_PENALTY', 0.1); | ||
| public static VIEW_HINT_PENALTY = 0.1 |
There was a problem hiding this comment.
Are semicolons needed at the ends of these lines? It seems inconsistent at the moment -- some have them and some don't. Let's be consistent.
(Probably prefer the version that has semicolons, since that's standard in JS, though I'm a little less famliiar with JS classes. @kevinlee12, any thoughts?)
There was a problem hiding this comment.
Semicolons aren't needed, though I can enable that eslint rule.
There was a problem hiding this comment.
Yep, let's stipulate a style, and have eslint check it, so that everything stays consistent.
| 'MODE_SELECT_DIFFICULTY', 'MODE_SELECT_DIFFICULTY'); | ||
| angular.module('oppia').constant('MODE_SELECT_SKILL', 'MODE_SELECT_SKILL'); | ||
| export class QuestionsListConstants { | ||
| public static DEFAULT_SKILL_DIFFICULTY = 0.3 |
There was a problem hiding this comment.
Ditto, inconsistencies in trailing semicolons. Please look out for these elsewhere.
@kevinlee12 we should perhaps turn on a lint check in eslint for this if there's one.
| 'EVENT_UNDO_REDO_SERVICE_CHANGE_APPLIED', 'undoRedoServiceChangeApplied'); | ||
| export class EditorDomainConstants { | ||
| public static EVENT_UNDO_REDO_SERVICE_CHANGE_APPLIED = | ||
| 'undoRedoServiceChangeApplied' |
| @@ -23,10 +23,13 @@ export class SkillDomainConstants { | |||
| '/skill_editor_handler/data/<skill_id>'; | |||
|
|
|||
| public static SKILL_DATA_URL_TEMPLATE = | |||
| '/skill_data_handler/<comma_separated_skill_ids>' | |||
| '/skill_data_handler/<comma_separated_skill_ids>'; | |||
Explanation
This PR upgrades constants to Angular 8. Also fixes #7292.
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.