Introduction to Angular 8 #7048
Conversation
|
I don't know, but the Travis checks on the main repo are the ones that
matter. You are welcome to add debugging logs and run builds on the main
repo to figure out what is going on, if you like. (You can change
.travis.yml temporarily to only run a subset of the tests so you get faster
results.)
One other possibility for the difference is whether your branch is up to
date with develop.
|
|
I found what was going wrong. Thanks to @apb7 who told me that although Travis runs on the code of my current branch but if there is a new file in develop then Travis takes that file too from develop even though it is absent from my local. I merged with develop and had that new file in my branch and the tests should now work fine. |
|
@YashJipkate, should do you another merge from develop? I noticed this failure: https://travis-ci.org/oppia/oppia/jobs/552214579#L3725 |
|
@kevinlee12 That issue has sprung up on all PRs ever since I cleared the cache on the repo. #7055 should be able to solve this. |
|
okay, thanks for letting me know! |
|
@apb7 @ankita240796 The backend tests have been running for 12 hours now. This shouldn't be happening and my PR is blocked due to it. Could you PTAL? /cc @seanlip |
|
I have no idea if this is the cause, but it looks like that build on CircleCI is referencing two PRs -- the one on your branch and the one on oppia/oppia. https://circleci.com/gh/YashJipkate/oppia/507 Not sure if this is an issue? I vaguely remember we had an issue like that before with running a local version of travis/circleCI tests (I think @sophiewu6 mentioned this) but I can't remember if it's the same thing or not. |
|
But I always had such an arrangement, where I had one local PR and one on this repo. This never happened in the past. Also, the tests seem to get stuck at one specific test i.e. core.domain.prod_validation_jobs_one_off_test and then they restart. |
|
Ah, this may be related to #7040 then. @ankita240796? |
|
Hi @YashJipkate, I am not sure if this is related to #7040 since in that case too it should take 3 hours to finish this up. I am trying to fix backend test run time by #7040 ASAP and I really sorry for the trouble. Thanks! |
|
@YashJipkate, I think this is related to #7040 since CircleCI seems to be timing out. Thanks! |
|
This passes tests. I'm merging it! |
Explanation
This PR is all #7027 plus a fix for the bug reported thanks to @sophiewu6!
Checklist
python scripts/pre_commit_linter.pyandbash scripts/run_frontend_tests.sh.