Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduction to Angular 8. #7027

Merged
merged 34 commits into from
Jun 28, 2019
Merged

Introduction to Angular 8. #7027

merged 34 commits into from
Jun 28, 2019

Conversation

YashJipkate
Copy link
Contributor

@YashJipkate YashJipkate commented Jun 26, 2019 •
edited
Loading

Explanation

This PR hybridizes the codebase to introduce Angular 8 to the codebase.

Summary of changes:

  • Every file that used the oppia global variable reference has a one-line addition that imports the hybridized module from AppInit.ts.
  • AppInit.ts is the main file responsible for the hybridizing.
  • Karma: The karma now runs by combining all the spec files to a single file and run the tests. The tests fail on running from separate files due to some unknown reasons.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

@YashJipkate YashJipkate reopened this Jun 27, 2019
vojtechjelinek
vojtechjelinek suggested changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Last few things.

core/templates/dev/head/pages/about-page/about-page.scripts.ts Show resolved Hide resolved
core/templates/dev/head/pages/signup-page/signup-page.controller.spec.ts Outdated Show resolved Hide resolved
core/tests/karma.conf.ts Show resolved Hide resolved
@YashJipkate YashJipkate reopened this Jun 27, 2019
seanlip
seanlip approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my standpoint.

@vojtechjelinek PTAL, once you approve, this can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Jun 27, 2019

Hi @YashJipkate. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

vojtechjelinek
vojtechjelinek approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YashJipkate YashJipkate reopened this Jun 27, 2019
@seanlip
Copy link
Member

seanlip commented Jun 27, 2019

Confirming that I'm happy to merge this once Travis passes.

@seanlip
Copy link
Member

seanlip commented Jun 28, 2019

I'm a bit confused about this. Seems like the backend tests on Circle-CI have been running for a total of 4 hours? Might want to look into what's going on here.

/cc @oppia/dev-workflow-team

@kevinlee12
Copy link
Contributor

kevinlee12 commented Jun 28, 2019 •
edited
Loading

It looks like the backend test is being restarted automatically by CircleCI. Looking at another PR, it took 2 hours 20 mins to pass the backend test, which is definitely not normal.

@kevinlee12
Copy link
Contributor

@seanlip, tests finally pass!

@seanlip seanlip merged commit e1bb364 into oppia:develop Jun 28, 2019
@seanlip
Copy link
Member

seanlip commented Jun 28, 2019

Merged. But someone really should look at the backend tests -- why are they taking so long? /cc @oppia/dev-workflow-team

@apb7
Copy link
Contributor

apb7 commented Jun 28, 2019

Hi, I checked this out:

But someone really should look at the backend tests -- why are they taking so long? /cc @oppia/dev-workflow-team

The CI is working fine but post #7023 and its merging, this test file:
SUCCESS core.domain.prod_validation_jobs_one_off_test: 760 tests (10306.5 secs)
is literally taking more than 2 hours.

/cc @ankita240796.

seanlip added a commit that referenced this pull request Jun 28, 2019
@seanlip
Revert "Introduction to Angular 8. (#7027)"
cbe92f4 
This reverts commit e1bb364.
@seanlip seanlip mentioned this pull request Jun 28, 2019
Merged
seanlip added a commit that referenced this pull request Jun 28, 2019
@seanlip
Revert "Introduction to Angular 8. (#7027)" (#7038)
7038a63 
This reverts commit e1bb364.
@YashJipkate YashJipkate mentioned this pull request Jun 28, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanlip seanlip seanlip approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@aks681 aks681 Awaiting requested review from aks681

@AllanYangZhou AllanYangZhou Awaiting requested review from AllanYangZhou

@ankita240796 ankita240796 Awaiting requested review from ankita240796

@apb7 apb7 Awaiting requested review from apb7

@bansalnitish bansalnitish Awaiting requested review from bansalnitish

@brianrodri brianrodri Awaiting requested review from brianrodri

@DubeySandeep DubeySandeep Awaiting requested review from DubeySandeep

@jameesjohn jameesjohn Awaiting requested review from jameesjohn

@nithusha21 nithusha21 Awaiting requested review from nithusha21

@prasanna08 prasanna08 Awaiting requested review from prasanna08

@sophiewu6 sophiewu6 Awaiting requested review from sophiewu6

@vinitamurthi vinitamurthi Awaiting requested review from vinitamurthi

Assignees

@vojtechjelinek vojtechjelinek

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YashJipkate @kevinlee12 @seanlip @apb7 @vojtechjelinek