Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate remaining constants into individual files. #6996

Merged
merged 13 commits into from
Jun 25, 2019
Merged

Separate remaining constants into individual files. #6996

merged 13 commits into from
Jun 25, 2019

Conversation

YashJipkate
Copy link
Contributor

Explanation

This PR cleans up all the remaining constants from the codebase into separate files.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

seanlip
seanlip approved these changes Jun 23, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, but generally I have no concerns. Thanks!

.github/CODEOWNERS Outdated
@@ -427,6 +427,7 @@
/core/templates/dev/head/pages/profile-page/ @kevinlee12
/core/templates/dev/head/services/UserService*.ts @kevinlee12

/core/templates/dev/head/services/services.constants.ts @kevinlee12 @seanlip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note, I don't need to own this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them as I wasn't sure whom to add. Will remove your name. @kevinlee12 Are you ok with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is fine.

@seanlip seanlip assigned vojtechjelinek and unassigned seanlip Jun 23, 2019
@seanlip
Copy link
Member

seanlip commented Jun 23, 2019

@kevinlee12 @vojtechjelinek could you PTAL too?

Once you both approve I can merge this.

ankita240796
ankita240796 approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@ankita240796 ankita240796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @YashJipkate. Please drop the changes in package-lock.json.

package-lock.json Outdated
@@ -2086,7 +2086,6 @@
"anymatch": "^2.0.0",
"async-each": "^1.0.1",
"braces": "^2.3.2",
"fsevents": "^1.2.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashJipkate, did you address this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was fixed. But it still does that. Reverted the change.

kevinlee12
kevinlee12 approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

however, it looks like there are lint tests failing: https://travis-ci.org/oppia/oppia/jobs/549301164#L3740

@kevinlee12 kevinlee12 assigned YashJipkate and unassigned kevinlee12 Jun 23, 2019
bansalnitish
bansalnitish approved these changes Jun 23, 2019
View reviewed changes
Copy link
Contributor

@bansalnitish bansalnitish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (As code owner)

@YashJipkate YashJipkate reopened this Jun 23, 2019
@YashJipkate YashJipkate reopened this Jun 23, 2019
@kevinlee12
Copy link
Contributor

@YashJipkate, ptal at backend test failure!

@YashJipkate YashJipkate reopened this Jun 24, 2019
@YashJipkate
Copy link
Contributor Author

HI @kevinlee12 The tests pass! PTAL!

kevinlee12
kevinlee12 approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 assigned seanlip and unassigned YashJipkate Jun 25, 2019
@YashJipkate YashJipkate reopened this Jun 25, 2019
@YashJipkate
Copy link
Contributor Author

Hi @kevinlee12 @seanlip The changes to package-lock.json have been reverted and the checks pass. PTAL!

@seanlip
Copy link
Member

seanlip commented Jun 25, 2019

See my earlier message -- once @vojtechjelinek approves I will merge this.

vojtechjelinek
vojtechjelinek approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@vojtechjelinek vojtechjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanlip seanlip merged commit 7ad9d06 into oppia:develop Jun 25, 2019
@YashJipkate YashJipkate mentioned this pull request Jun 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinlee12 kevinlee12 kevinlee12 approved these changes

@bansalnitish bansalnitish bansalnitish approved these changes

@ankita240796 ankita240796 ankita240796 approved these changes

@seanlip seanlip seanlip approved these changes

@vojtechjelinek vojtechjelinek vojtechjelinek approved these changes

@aks681 aks681 Awaiting requested review from aks681

@AllanYangZhou AllanYangZhou Awaiting requested review from AllanYangZhou

@apb7 apb7 Awaiting requested review from apb7

@brianrodri brianrodri Awaiting requested review from brianrodri

@prasanna08 prasanna08 Awaiting requested review from prasanna08

Assignees

@vojtechjelinek vojtechjelinek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YashJipkate @seanlip @kevinlee12 @vojtechjelinek @ankita240796 @bansalnitish