Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate constants in domain/ into individual files. #6968

Merged
merged 13 commits into from
Jun 20, 2019
Merged

Separate constants in domain/ into individual files. #6968

merged 13 commits into from
Jun 20, 2019

Conversation

YashJipkate
Copy link
Contributor

Explanation

This PR separates constants in domain/ into individual files.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12
Copy link
Contributor

@YashJipkate, just a heads up that I'm going to close and re-open this PR to trigger the CircleCI tests.

@kevinlee12 kevinlee12 closed this Jun 19, 2019
@kevinlee12 kevinlee12 reopened this Jun 19, 2019
@YashJipkate YashJipkate reopened this Jun 19, 2019
@YashJipkate
Copy link
Contributor Author

@kevinlee12 The CircleCI still isn't responding. I am making a minor commit to see if it triggers it.

@YashJipkate
Copy link
Contributor Author

Ok, so CircleCI responded but Travis didn't; Closing and reopening again.

@YashJipkate YashJipkate reopened this Jun 19, 2019
@seanlip seanlip removed their assignment Jun 19, 2019
@DubeySandeep DubeySandeep removed their assignment Jun 19, 2019
Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jun 19, 2019

Hi @YashJipkate. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@YashJipkate
Copy link
Contributor Author

HI @seanlip @kevinlee12 Could this be merged?
Thanks!

@kevinlee12 kevinlee12 merged commit 18f1a53 into oppia:develop Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants