-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate constants in domain/ into individual files. #6968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@YashJipkate, just a heads up that I'm going to close and re-open this PR to trigger the CircleCI tests. |
@kevinlee12 The CircleCI still isn't responding. I am making a minor commit to see if it triggers it. |
Ok, so CircleCI responded but Travis didn't; Closing and reopening again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @YashJipkate. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks! |
HI @seanlip @kevinlee12 Could this be merged? |
Explanation
This PR separates constants in domain/ into individual files.
Checklist
python scripts/pre_commit_linter.py
andbash scripts/run_frontend_tests.sh
.