Upgrades Requests #6965

NishealJ · 2019-06-17T23:11:14Z

Explanation

This PR Upgrades Requests to its latest version,
to view the upgrade status of all the libraries please visit here
For testing doc please visit here

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
The PR is made from a branch that's not called "develop".
The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
The PR follows the style guide.
The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

NishealJ · 2019-06-17T23:11:55Z

Hi @apb7,
I've added the testing doc here Thanks!

apb7

Hi @NishealJ, ptal!

apb7 · 2019-06-18T06:49:27Z

appengine_config.py

@@ -97,7 +97,7 @@ def save(self):
    os.path.join(ROOT_PATH, 'third_party', 'graphy-1.0.0'),
    os.path.join(ROOT_PATH, 'third_party', 'html5lib-python-1.0.1'),
    os.path.join(ROOT_PATH, 'third_party', 'mutagen-1.38'),
-    os.path.join(ROOT_PATH, 'third_party', 'requests-2.10.0'),
+    os.path.join(ROOT_PATH, 'third_party', 'requests-2.21.0'),


The latest version of requests shown here is 2.22. We should be upgrading to 2.22 then.

Hi @apb7, yes 2.22 is the latest but the changelog mentioned that they have officially stopped support for Python 3.4 as there was an ongoing project for migrating the code to python 3 I was not sure and i upgraded it to the latest feasible version

No, I think we should be going for 2.22 since it supports Python 2.7 and >=3.5. At the moment, we're only making the code base easier to migrate to Python 3 (and not any specific version).

Hi @apb7 Sounds good to me, I've updated the version and the changes are trivial. Thanks!

Tests are failing with error

Parse error at third_party/generated/js/third_party.js:21644,12 import * as util from './util'; ^ ERROR: Unexpected token: name «util», expected: punc «;»

I'll try to debug Thanks!

Hi @apb7, The above failing tests has been resolved Thanks!

codecov · 2019-06-18T07:43:35Z

Codecov Report

Merging #6965 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6965   +/-   ##
========================================
  Coverage    95.74%   95.74%           
========================================
  Files          371      371           
  Lines        51651    51651           
========================================
  Hits         49451    49451           
  Misses        2200     2200

Impacted Files	Coverage Δ
appengine_config.py	`50% <ø> (ø)`	⬆️
core/tests/gae_suite.py	`74.41% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ca6d0...cfd6ae0. Read the comment docs.

codecov · 2019-06-18T07:43:35Z

Codecov Report

Merging #6965 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6965   +/-   ##
========================================
  Coverage    95.73%   95.73%           
========================================
  Files          371      371           
  Lines        51604    51604           
========================================
  Hits         49404    49404           
  Misses        2200     2200

Impacted Files	Coverage Δ
appengine_config.py	`50% <ø> (ø)`	⬆️
core/tests/gae_suite.py	`74.41% <ø> (ø)`	⬆️
core/controllers/pages_test.py	`100% <0%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe56fa...aa49f7b. Read the comment docs.

apb7

LGTM, thanks, @NishealJ! Hi @nithusha21, @seanlip and @vojtechjelinek, can you please ptal as code owners? Thanks!

This reverts commit f13a410.

NishealJ added 2 commits June 18, 2019 01:42

initial up

18fefe6

revert messgae format

86afb9e

NishealJ added the CHANGELOG: Code health label Jun 17, 2019

NishealJ requested review from apb7, nithusha21, seanlip and vojtechjelinek as code owners June 17, 2019 23:11

NishealJ self-assigned this Jun 17, 2019

apb7 suggested changes Jun 18, 2019

View reviewed changes

Change verison

aa49f7b

Merge remote-tracking branch 'origin/develop' into requests-2

cfd6ae0

apb7 approved these changes Jun 19, 2019

View reviewed changes

apb7 assigned vojtechjelinek, seanlip and nithusha21 and unassigned NishealJ Jun 19, 2019

seanlip approved these changes Jun 19, 2019

View reviewed changes

seanlip merged commit f13a410 into oppia:develop Jun 19, 2019

seanlip added a commit that referenced this pull request Jul 4, 2019

Revert "Upgrades Requests (#6965)"

c8dcae4

This reverts commit f13a410.

seanlip mentioned this pull request Jul 4, 2019

Revert "Upgrades Requests (#6965)" #7088

Merged

8 tasks

seanlip added a commit that referenced this pull request Jul 4, 2019

Revert "Upgrades Requests (#6965)" (#7088)

e1d2202

This reverts commit f13a410.

seanlip added a commit that referenced this pull request Jul 4, 2019

Revert "Upgrades Requests (#6965)" (#7088)

1a561e9

This reverts commit f13a410.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades Requests #6965

Upgrades Requests #6965

NishealJ commented Jun 17, 2019

NishealJ commented Jun 17, 2019

apb7 left a comment

apb7 Jun 18, 2019

NishealJ Jun 18, 2019 •

edited

Loading

apb7 Jun 18, 2019

NishealJ Jun 18, 2019 •

edited

Loading

NishealJ Jun 18, 2019 •

edited

Loading

NishealJ Jun 19, 2019

codecov bot commented Jun 18, 2019 •

edited

Loading

codecov bot commented Jun 18, 2019

apb7 left a comment

Upgrades Requests #6965

Upgrades Requests #6965

Conversation

NishealJ commented Jun 17, 2019

Explanation

Checklist

NishealJ commented Jun 17, 2019

apb7 left a comment

Choose a reason for hiding this comment

apb7 Jun 18, 2019

Choose a reason for hiding this comment

NishealJ Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

apb7 Jun 18, 2019

Choose a reason for hiding this comment

NishealJ Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

NishealJ Jun 18, 2019 • edited Loading

Choose a reason for hiding this comment

NishealJ Jun 19, 2019

Choose a reason for hiding this comment

codecov bot commented Jun 18, 2019 • edited Loading

Codecov Report

codecov bot commented Jun 18, 2019

Codecov Report

apb7 left a comment

Choose a reason for hiding this comment

NishealJ Jun 18, 2019 •

edited

Loading

NishealJ Jun 18, 2019 •

edited

Loading

NishealJ Jun 18, 2019 •

edited

Loading

codecov bot commented Jun 18, 2019 •

edited

Loading