Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6914: Remove unused setup code that is causing breakages on some systems. #6942

Merged
merged 1 commit into from
Jun 16, 2019
Merged

Fix #6914: Remove unused setup code that is causing breakages on some systems. #6942

merged 1 commit into from
Jun 16, 2019

Conversation

seanlip
Copy link
Member

@seanlip seanlip commented Jun 16, 2019

Explanation

Hopefully this fixes #6914 (i.e. the npm issues)! Thanks to @sophiewu6 for filing #6914.

Relevant comment: #6914 (comment)

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.

@seanlip seanlip requested a review from sophiewu6 June 16, 2019 03:01
@seanlip seanlip requested a review from apb7 as a code owner June 16, 2019 03:01
apb7
apb7 approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@apb7 apb7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @seanlip!

@apb7 apb7 removed their assignment Jun 16, 2019
@seanlip
Copy link
Member Author

seanlip commented Jun 16, 2019

@sophiewu6, I think we're going to merge this once the checks pass. Once that happens could you please confirm that the error is fixed on your end?

Thanks!

sophiewu6
sophiewu6 approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@sophiewu6 sophiewu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tried on my computer and it fixed that issue. Thanks Sean!

@seanlip
Copy link
Member Author

seanlip commented Jun 16, 2019

Yay! Thanks for confirming @sophiewu6 :D

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #6942 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6942   +/-   ##
========================================
  Coverage    95.73%   95.73%           
========================================
  Files          371      371           
  Lines        51604    51604           
========================================
  Hits         49404    49404           
  Misses        2200     2200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdd42c...d974e49. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #6942 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6942   +/-   ##
========================================
  Coverage    95.73%   95.73%           
========================================
  Files          371      371           
  Lines        51604    51604           
========================================
  Hits         49404    49404           
  Misses        2200     2200

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdd42c...d974e49. Read the comment docs.

@seanlip seanlip merged commit c805d2d into develop Jun 16, 2019
@seanlip seanlip deleted the remove-unused-setup-code branch June 16, 2019 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewu6 sophiewu6 sophiewu6 approved these changes

@apb7 apb7 apb7 approved these changes

Assignees

@sophiewu6 sophiewu6

Labels
PR: LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm error due to package-lock.json when running any script
3 participants
@seanlip @apb7 @sophiewu6