Upgrades code-mirror, browsermob-proxy and mouse-trap #6940

NishealJ · 2019-06-16T00:17:21Z

Explanation

This PR Upgrades code-mirror, browsermob-proxy and mouse-trap,
To see the upgrade status please visit here

For testing doc please visit here

Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
The PR is made from a branch that's not called "develop".
The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
The PR follows the style guide.
The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

codecov · 2019-06-16T09:56:54Z

Codecov Report

Merging #6940 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6940   +/-   ##
========================================
  Coverage    95.73%   95.73%           
========================================
  Files          371      371           
  Lines        51604    51604           
========================================
  Hits         49404    49404           
  Misses        2200     2200

Impacted Files	Coverage Δ
core/tests/gae_suite.py	`74.41% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdd42c...8b8a6a9. Read the comment docs.

codecov · 2019-06-16T09:56:54Z

Codecov Report

Merging #6940 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #6940   +/-   ##
=======================================
  Coverage     96.7%   96.7%           
=======================================
  Files          374     374           
  Lines        57508   57508           
=======================================
  Hits         55611   55611           
  Misses        1897    1897

Impacted Files	Coverage Δ
core/tests/gae_suite.py	`74.41% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a5dec...742557d. Read the comment docs.

nithusha21 · 2019-06-17T09:38:45Z

Hi @NishealJ, just noting that your PRs don't have a changelog label. Could you pick an appropriate one for all of your PRs? Simplifies the release process for us. Also, @apb7 before merging the PRs, could you make sure there is a label? Thanks!

NishealJ · 2019-06-18T20:07:16Z

Hi @apb7,
here the testing doc Please let me know if you have any specific tests in mind. PTAL Thanks!

apb7 · 2019-06-19T07:30:03Z

Hi @NishealJ, can you please add more tests for browsermob-proxy and mouse-trap according to the changelogs (as discussed)? Thanks!

NishealJ · 2019-06-19T12:49:29Z

Hi @NishealJ, can you please add more tests for browsermob-proxy and mouse-trap according to the changelogs (as discussed)? Thanks!

Hi @apb7, I've updated the testing doc seeing the changelog and the changelog dint had much of breaking of breaking changes Thanks!

NishealJ · 2019-06-20T08:20:23Z

Hi @seanlip & @apb7 PTAL Thanks!

NishealJ · 2019-06-26T21:37:03Z

Hi @apb7 Addressed your comments Thanks!

NishealJ · 2019-06-27T18:08:42Z

Hi, @DubeySandeep & @apb7 Addressed all your comments Thanks!

DubeySandeep

LGTM! (For the changes in e2e test file.)

core/tests/protractor_utils/ExplorationEditorHistoryTab.js

core/tests/protractor_utils/forms.js

nithusha21

LGTM. Just one question.

package-lock.json

apb7

LGTM, thanks @NishealJ!

seanlip · 2019-06-28T17:34:47Z

The Travis tests are failing.

apb7 · 2019-06-28T17:37:15Z

@NishealJ, the lint tests are failing with the following log:

/home/travis/build/oppia/oppia/core/tests/protractor_utils/forms.js
  644:1  error  Line 644 exceeds the maximum line length of 80  max-len

âœ– 1 problem (1 error, 0 warnings)


FAILED    1 JavaScript and Typescript files

Did you bypass the pre-push checks?

NishealJ · 2019-06-28T17:43:00Z

Ah, updated the code style I hope it gets a queue fast.
Thankyou @apb7 & @seanlip for the notifications.

NishealJ · 2019-06-28T17:44:41Z

@NishealJ, the lint tests are failing with the following log:

/home/travis/build/oppia/oppia/core/tests/protractor_utils/forms.js
  644:1  error  Line 644 exceeds the maximum line length of 80  max-len

âœ– 1 problem (1 error, 0 warnings)


FAILED    1 JavaScript and Typescript files

Did you bypass the pre-push checks?

Hi @apb7 I bypassed it thinking the change is very minor and it takes time to run, I usually don't do it for other commits Thanks!

seanlip · 2019-06-28T18:06:45Z

In the future, please never bypass the pre-push checks. Most errors come from exactly that -- i.e. submitters thinking that the change is very minor. Saving 2 minutes at that point can lead to a 2 hour delay while you wait for tests to re-run -- as you've seen!

NishealJ · 2019-06-28T18:09:24Z

In the future, please never bypass the pre-push checks. Most errors come from exactly that -- i.e. submitters thinking that the change is very minor. Saving 2 minutes at that point can lead to a 2 hour delay while you wait for tests to re-run -- as you've seen!

Sure @seanlip, I agree :)!

Initial upgrade

f1e6dd2

NishealJ added WIP labels Jun 16, 2019

NishealJ requested review from apb7, nithusha21, seanlip and vojtechjelinek as code owners June 16, 2019 00:17

NishealJ self-assigned this Jun 16, 2019

test

8b8a6a9

NishealJ added 2 commits June 17, 2019 11:51

update ui-code mirror

cfc573b

Update diff_match

b45b66a

apb7 added the CHANGELOG: Code health label Jun 17, 2019

Change the version of code-mirror

a02543a

apb7 removed the PR: don't merge - UNTESTED label Jun 18, 2019

Merge

b61f1db

NishealJ removed the WIP label Jun 18, 2019

NishealJ added the WIP label Jun 19, 2019

Fresh package-lock.json

be3b3bc

NishealJ removed the WIP label Jun 19, 2019

NishealJ added 3 commits June 20, 2019 11:08

Merge remote-tracking branch 'origin/develop' into ui-utills

580da3d

Merge conflicts

583e2b7

Merge conflicts-2

502842b

Merge remote-tracking branch 'origin/develop' into ui-utills

c0c76ad

Update docstrings

09bbcda

NishealJ requested review from apb7 and DubeySandeep June 27, 2019 06:59

apb7 unassigned seanlip and apb7 Jun 27, 2019

NishealJ added 2 commits June 27, 2019 20:51

Add scroll to checker

9749d50

Fix Lint

da0a5b6

NishealJ assigned DubeySandeep Jun 27, 2019

NishealJ assigned nithusha21 Jun 27, 2019

seanlip assigned apb7 Jun 27, 2019

DubeySandeep approved these changes Jun 28, 2019

View reviewed changes

core/tests/protractor_utils/ExplorationEditorHistoryTab.js Outdated Show resolved Hide resolved

core/tests/protractor_utils/forms.js Outdated Show resolved Hide resolved

DubeySandeep removed their assignment Jun 28, 2019

Minor Nits

346ef9d

nithusha21 approved these changes Jun 28, 2019

View reviewed changes

package-lock.json Show resolved Hide resolved

nithusha21 removed their assignment Jun 28, 2019

NishealJ added 3 commits June 28, 2019 13:39

Revert Package lock

934d65b

Revert Package lock

591ecb7

update string

e243a34

apb7 approved these changes Jun 28, 2019

View reviewed changes

apb7 removed their assignment Jun 28, 2019

Minnor nits

742557d

apb7 merged commit 4081b19 into oppia:develop Jun 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrades code-mirror, browsermob-proxy and mouse-trap #6940

Upgrades code-mirror, browsermob-proxy and mouse-trap #6940

NishealJ commented Jun 16, 2019 •

edited

Loading

codecov bot commented Jun 16, 2019

codecov bot commented Jun 16, 2019 •

edited

Loading

nithusha21 commented Jun 17, 2019

NishealJ commented Jun 18, 2019

apb7 commented Jun 19, 2019

NishealJ commented Jun 19, 2019

NishealJ commented Jun 20, 2019

NishealJ commented Jun 26, 2019

NishealJ commented Jun 27, 2019

DubeySandeep left a comment

nithusha21 left a comment

apb7 left a comment

seanlip commented Jun 28, 2019

apb7 commented Jun 28, 2019

NishealJ commented Jun 28, 2019

NishealJ commented Jun 28, 2019

seanlip commented Jun 28, 2019

NishealJ commented Jun 28, 2019

Upgrades code-mirror, browsermob-proxy and mouse-trap #6940

Upgrades code-mirror, browsermob-proxy and mouse-trap #6940

Conversation

NishealJ commented Jun 16, 2019 • edited Loading

Explanation

Checklist

codecov bot commented Jun 16, 2019

Codecov Report

codecov bot commented Jun 16, 2019 • edited Loading

Codecov Report

nithusha21 commented Jun 17, 2019

NishealJ commented Jun 18, 2019

apb7 commented Jun 19, 2019

NishealJ commented Jun 19, 2019

NishealJ commented Jun 20, 2019

NishealJ commented Jun 26, 2019

NishealJ commented Jun 27, 2019

DubeySandeep left a comment

Choose a reason for hiding this comment

nithusha21 left a comment

Choose a reason for hiding this comment

apb7 left a comment

Choose a reason for hiding this comment

seanlip commented Jun 28, 2019

apb7 commented Jun 28, 2019

NishealJ commented Jun 28, 2019

NishealJ commented Jun 28, 2019

seanlip commented Jun 28, 2019

NishealJ commented Jun 28, 2019

NishealJ commented Jun 16, 2019 •

edited

Loading

codecov bot commented Jun 16, 2019 •

edited

Loading