Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SuggestionModalService to services/ #6935

Merged
merged 4 commits into from
Jun 17, 2019
Merged

Move SuggestionModalService to services/ #6935

merged 4 commits into from
Jun 17, 2019

Conversation

YashJipkate
Copy link
Contributor

Explanation

This PR moves SuggestionModalService to services/ as decided in folders-by-feature.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The linter/Karma presubmit checks have passed.
    • These should run automatically, but if not, you can manually trigger them locally using python scripts/pre_commit_linter.py and bash scripts/run_frontend_tests.sh.
  • The PR is made from a branch that's not called "develop".
  • The PR has an appropriate "CHANGELOG: ..." label (If you are unsure of which label to add, ask the reviewers for guidance).
  • The PR follows the style guide.
  • The PR addresses the points mentioned in the codeowner checks for the files/folders changed. (See the codeowner's wiki page.)
  • The PR is assigned to an appropriate reviewer.
    • If you're a new contributor, please ask on Gitter for someone to assign a reviewer and don't tick this checkbox.
    • If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue. Do not only request the review but also add the reviewer as an assignee.

seanlip
seanlip reviewed Jun 15, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues, just one question.

.github/CODEOWNERS Outdated
@@ -429,8 +429,6 @@
#
# https://help.github.com/en/articles/about-code-owners
#
# On modifying this list make sure to keep the CODEOWNER_IMPORTANT_PATHS list
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete? /cc @DubeySandeep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that was unintentional. Sorry for that. Fixed!

DubeySandeep
DubeySandeep approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashJipkate, LGTM! (Just a few simple comments.)

...e/suggestion-modal-for-learner-local-view/suggestion-modal-for-exploration-player.service.ts
@@ -20,7 +20,7 @@ require('domain/utilities/UrlInterpolationService.ts');
require('pages/exploration-player-page/services/exploration-engine.service.ts');
require('pages/exploration-player-page/services/player-position.service.ts');
require('pages/exploration-player-page/services/player-transcript.service.ts');
require('pages/suggestion_editor/SuggestionModalService.ts');
require('services/SuggestionModalService.ts');
require('services/AlertsService.ts');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go above (alphabetically sorted order), right?

...tor-page/suggestion-modal-for-editor-view/suggestion-modal-for-exploration-editor.service.ts Outdated
@@ -22,7 +22,7 @@ require('pages/exploration-editor-page/services/exploration-data.service.ts');
require('pages/exploration-editor-page/services/exploration-states.service.ts');
require(
'pages/exploration-editor-page/feedback-tab/services/thread-data.service.ts');
require('pages/suggestion_editor/SuggestionModalService.ts');
require('services/SuggestionModalService.ts');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

@DubeySandeep
Copy link
Member

Assigned all codeowners as this PR is pretty small and can be reviewed/approved by others at the same time.
(@nithusha21 & @aks681 Can you please review this PR as a code-owner?)

kevinlee12
kevinlee12 approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor

@kevinlee12 kevinlee12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kevinlee12 kevinlee12 removed their assignment Jun 15, 2019
seanlip
seanlip approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanlip seanlip removed their assignment Jun 16, 2019
@seanlip
Copy link
Member

seanlip commented Jun 16, 2019

@nithusha21 @aks681 PTAL

aks681
aks681 approved these changes Jun 16, 2019
View reviewed changes
Copy link
Contributor

@aks681 aks681 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aks681 aks681 removed their assignment Jun 16, 2019
nithusha21
nithusha21 approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@nithusha21 nithusha21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nithusha21 nithusha21 merged commit d188598 into oppia:develop Jun 17, 2019
@YashJipkate YashJipkate deleted the move-sug-modal branch July 15, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aks681 aks681 aks681 approved these changes

@DubeySandeep DubeySandeep DubeySandeep approved these changes

@nithusha21 nithusha21 nithusha21 approved these changes

@seanlip seanlip seanlip approved these changes

@kevinlee12 kevinlee12 kevinlee12 approved these changes

Assignees

@nithusha21 nithusha21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YashJipkate @DubeySandeep @seanlip @kevinlee12 @nithusha21 @aks681